Re: Pty is losing bytes

Theodore Ts'o
2005-02-17T04:45:14Z

On Wed, Feb 16, 2005 at 08:06:00AM -0800, Linus Torvalds wrote:
> Yes, yes, but did you see my suggested version that I had just below that
> explained what I thought the real fix was?
>
> Th eproblem with checking for the "canon but no canon data" is that it's a
> special case that IS ONLY VALID WHEN THE BUFFER IS FULL! Until that
> happens, it means that the code returns the wrong value, and then can
> (obviously, as seen by the bug) drop bytes even when it shouldn't.
>
> That's why my suggested work-around moved things around, to only return
> the "we'll take anything" thing if the buffer really was full.

Yes, but then when the buffer is full, and we return the "we'll take
anything" return value, the code that was getting confused with the
"incorrect" receive_room value will still be getting confused....

- Ted