public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: dtor_core@ameritech.net
Cc: Kay Sievers <kay.sievers@vrfy.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add "bus" symlink to class/block devices
Date: Tue, 15 Feb 2005 15:44:15 -0800	[thread overview]
Message-ID: <20050215234415.GA17680@kroah.com> (raw)
In-Reply-To: <d120d50005021514251492dd10@mail.gmail.com>

On Tue, Feb 15, 2005 at 05:25:54PM -0500, Dmitry Torokhov wrote:
> On Tue, 15 Feb 2005 23:04:06 +0100, Kay Sievers <kay.sievers@vrfy.org> wrote:
> > 
> > -static int class_device_dev_link(struct class_device * class_dev)
> > -{
> > -       if (class_dev->dev)
> > -               return sysfs_create_link(&class_dev->kobj,
> > -                                        &class_dev->dev->kobj, "device");
> > -       return 0;
> > -}
> > -
> > -static void class_device_dev_unlink(struct class_device * class_dev)
> > -{
> > -       sysfs_remove_link(&class_dev->kobj, "device");
> > -}
> > -
> 
> Hi,
> 
> I can agree on dropping driver link but I think that the link to
> underlying real device is still needed.

It's still there, read the patch :)

thanks,

greg k-h

  reply	other threads:[~2005-02-16  0:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-15 20:53 [PATCH ] add "bus" symlink to class/block devices Kay Sievers
2005-02-15 22:04 ` [PATCH] " Kay Sievers
2005-02-15 22:25   ` Dmitry Torokhov
2005-02-15 23:44     ` Greg KH [this message]
2005-02-16  3:18       ` Dmitry Torokhov
2005-02-17 21:35   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050215234415.GA17680@kroah.com \
    --to=greg@kroah.com \
    --cc=dtor_core@ameritech.net \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox