* [2.6 patch] drivers/net/lp486e.c: make some code static
@ 2005-02-17 20:54 Adrian Bunk
2005-02-21 1:47 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2005-02-17 20:54 UTC (permalink / raw)
To: jgarzik; +Cc: linux-net, linux-kernel
This patch makes some needlessly global code static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/net/lp486e.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
--- linux-2.6.11-rc3-mm2-full/drivers/net/lp486e.c.old 2005-02-16 16:08:34.000000000 +0100
+++ linux-2.6.11-rc3-mm2-full/drivers/net/lp486e.c 2005-02-16 16:15:33.000000000 +0100
@@ -112,8 +112,10 @@
CmdDiagnose = 7
};
-char *CUcmdnames[8] = { "NOP", "IASetup", "Configure", "MulticastList",
- "Tx", "TDR", "Dump", "Diagnose" };
+#if 0
+static char *CUcmdnames[8] = { "NOP", "IASetup", "Configure", "MulticastList",
+ "Tx", "TDR", "Dump", "Diagnose" };
+#endif
/* Status word bits */
#define STAT_CX 0x8000 /* The CU finished executing a command
@@ -960,7 +962,7 @@
(unsigned char) add[12], (unsigned char) add[13]);
}
-int __init lp486e_probe(struct net_device *dev) {
+static int __init lp486e_probe(struct net_device *dev) {
struct i596_private *lp;
unsigned char eth_addr[6] = { 0, 0xaa, 0, 0, 0, 0 };
unsigned char *bios;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] drivers/net/lp486e.c: make some code static
2005-02-17 20:54 [2.6 patch] drivers/net/lp486e.c: make some code static Adrian Bunk
@ 2005-02-21 1:47 ` Jeff Garzik
2005-02-21 14:47 ` Adrian Bunk
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2005-02-21 1:47 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-net, linux-kernel
Adrian Bunk wrote:
> This patch makes some needlessly global code static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> drivers/net/lp486e.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
> --- linux-2.6.11-rc3-mm2-full/drivers/net/lp486e.c.old 2005-02-16 16:08:34.000000000 +0100
> +++ linux-2.6.11-rc3-mm2-full/drivers/net/lp486e.c 2005-02-16 16:15:33.000000000 +0100
> @@ -112,8 +112,10 @@
> CmdDiagnose = 7
> };
>
> -char *CUcmdnames[8] = { "NOP", "IASetup", "Configure", "MulticastList",
> - "Tx", "TDR", "Dump", "Diagnose" };
> +#if 0
> +static char *CUcmdnames[8] = { "NOP", "IASetup", "Configure", "MulticastList",
> + "Tx", "TDR", "Dump", "Diagnose" };
> +#endif
Need const.
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* [2.6 patch] drivers/net/lp486e.c: make some code static
2005-02-21 1:47 ` Jeff Garzik
@ 2005-02-21 14:47 ` Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2005-02-21 14:47 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-net, linux-kernel
On Sun, Feb 20, 2005 at 08:47:14PM -0500, Jeff Garzik wrote:
>...
> >+#if 0
> >+static char *CUcmdnames[8] = { "NOP", "IASetup", "Configure",
> >"MulticastList",
> >+ "Tx", "TDR", "Dump", "Diagnose" };
> >+#endif
>
> Need const.
Updated patch:
<-- snip -->
This patch makes some needlessly global code static and makes
CUcmdnames const.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/net/lp486e.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
--- linux-2.6.11-rc3-mm2-full/drivers/net/lp486e.c.old 2005-02-16 16:08:34.000000000 +0100
+++ linux-2.6.11-rc3-mm2-full/drivers/net/lp486e.c 2005-02-16 16:15:33.000000000 +0100
@@ -112,8 +112,10 @@
CmdDiagnose = 7
};
-char *CUcmdnames[8] = { "NOP", "IASetup", "Configure", "MulticastList",
- "Tx", "TDR", "Dump", "Diagnose" };
+#if 0
+static const char *CUcmdnames[8] = { "NOP", "IASetup", "Configure", "MulticastList",
+ "Tx", "TDR", "Dump", "Diagnose" };
+#endif
/* Status word bits */
#define STAT_CX 0x8000 /* The CU finished executing a command
@@ -960,7 +962,7 @@
(unsigned char) add[12], (unsigned char) add[13]);
}
-int __init lp486e_probe(struct net_device *dev) {
+static int __init lp486e_probe(struct net_device *dev) {
struct i596_private *lp;
unsigned char eth_addr[6] = { 0, 0xaa, 0, 0, 0, 0 };
unsigned char *bios;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-02-21 14:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-17 20:54 [2.6 patch] drivers/net/lp486e.c: make some code static Adrian Bunk
2005-02-21 1:47 ` Jeff Garzik
2005-02-21 14:47 ` Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox