Re: [PATCH] add I/O error uevent for block devices

[Andrew Morton <akpm@osdl.org>]

Kay Sievers <kay.sievers@vrfy.org> wrote:
>
> On Fri, Feb 18, 2005 at 11:02:32AM -0800, Andrew Morton wrote:
> > Kay Sievers <kay.sievers@vrfy.org> wrote:
> > >
> > >  > - there are numerous other places where an I/O error can be detected:
> > >  >   grep the tree for b_end_io and bio_end_io.
> > > 
> > >  You mean the mmap and direct-io stuff?
> > 
> > direct-io, certainly.  Also reiserfs, xfs, ntfs, ext3, jfs and possibly md
> > have their own I/O completion handlers.
> 
> Hmm, ok. Any idea how to propagate errors like this in a saner way? Some of
> these places don't even log errors and spreading uevents all over the place
> doesn't sounds like the best idea.
> 

I guess you should add some new generic function
handle_block_io_error(bdev, rw, sector) in ll_rw_blk.c and do whatever you
need to do inside that.  Move the ratelimited printk there, too.