* [2.6 patch] drivers/net/sunhme.c: make a struct static
@ 2005-02-19 8:36 Adrian Bunk
2005-03-10 4:44 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2005-02-19 8:36 UTC (permalink / raw)
To: davem; +Cc: jgarzik, linux-net, linux-kernel
This patch makes a needlessly global struct static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.11-rc3-mm2-full/drivers/net/sunhme.c.old 2005-02-16 18:48:13.000000000 +0100
+++ linux-2.6.11-rc3-mm2-full/drivers/net/sunhme.c 2005-02-16 19:04:48.000000000 +0100
@@ -175,13 +175,13 @@
#define DEFAULT_IPG2 4 /* For all modes */
#define DEFAULT_JAMSIZE 4 /* Toe jam */
-#ifdef CONFIG_PCI
+#if defined(CONFIG_PCI) && defined(MODULE)
/* This happy_pci_ids is declared __initdata because it is only used
as an advisory to depmod. If this is ported to the new PCI interface
where it could be referenced at any time due to hot plugging,
the __initdata reference should be removed. */
-struct pci_device_id happymeal_pci_ids[] = {
+static struct pci_device_id happymeal_pci_ids[] = {
{
.vendor = PCI_VENDOR_ID_SUN,
.device = PCI_DEVICE_ID_SUN_HAPPYMEAL,
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] drivers/net/sunhme.c: make a struct static
2005-02-19 8:36 [2.6 patch] drivers/net/sunhme.c: make a struct static Adrian Bunk
@ 2005-03-10 4:44 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2005-03-10 4:44 UTC (permalink / raw)
To: Adrian Bunk; +Cc: jgarzik, linux-net, linux-kernel
On Sat, 19 Feb 2005 09:36:18 +0100
Adrian Bunk <bunk@stusta.de> wrote:
> This patch makes a needlessly global struct static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Applied, thanks Adrian.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-03-10 4:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-19 8:36 [2.6 patch] drivers/net/sunhme.c: make a struct static Adrian Bunk
2005-03-10 4:44 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox