From: Greg KH <gregkh@suse.de>
To: Malcolm Rowe <malcolm-linux@farside.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Symlink /sys/class/block to /sys/block
Date: Tue, 22 Feb 2005 11:04:12 -0800 [thread overview]
Message-ID: <20050222190412.GA23687@suse.de> (raw)
In-Reply-To: <courier.4217CBC9.000027C1@mail.farside.org.uk>
On Sat, Feb 19, 2005 at 11:29:13PM +0000, Malcolm Rowe wrote:
> Greg,
>
> Following the discussion in [1], the attached patch creates /sys/class/block
> as a symlink to /sys/block. The patch applies to 2.6.11-rc4-bk7.
>
> Please cc: me on any replies - I'm not subscribed to the mailing list.
Hm, your patch is linewrapped, and can't be applied :(
But more importantly:
> @@ -406,6 +420,7 @@
> static void disk_release(struct kobject * kobj)
> {
> struct gendisk *disk = to_disk(kobj);
> + sysfs_remove_link(&class_subsys.kset.kobj, "block");
> kfree(disk->random);
> kfree(disk->part);
> free_disk_stats(disk);
Did you try to remove a disk (like a usb device) and see what happens
here? Hint, this isn't the proper place to remove the symlink...
thanks,
greg k-h
next prev parent reply other threads:[~2005-02-22 19:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-19 23:29 [PATCH] Symlink /sys/class/block to /sys/block Malcolm Rowe
2005-02-22 19:04 ` Greg KH [this message]
[not found] ` <courier.421C5047.00003EBA@mail.farside.org.uk>
2005-02-24 23:34 ` Greg KH
2005-02-25 1:35 ` Kay Sievers
2005-02-25 22:39 ` Greg KH
2005-02-25 23:53 ` Kay Sievers
2005-02-25 23:58 ` Greg KH
2005-02-22 23:06 ` Chris Wedgwood
2005-02-22 23:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050222190412.GA23687@suse.de \
--to=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=malcolm-linux@farside.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox