Re: [PATCH/RFC] Futex mmap_sem deadlock

Andrew Morton
2005-02-22T23:15:44Z

olof@austin.ibm.com (Olof Johansson) wrote:
>
> + inc_preempt_count();
> + ret = get_user(curval, (int __user *)uaddr1);
> + dec_preempt_count();

That _should_ generate a might_sleep() warning, except it looks like we
forgot to add a check to get_user().

It would be better to use __copy_from_user_inatomic() here, I think.