Re: [PATCH/RFC] Futex mmap_sem deadlock

Jamie Lokier
2005-02-22T22:10:40Z

Olof Johansson wrote:
> > That won't work because the vma lock must be help between key
> > calculation and get_user() - otherwise futex is not reliable. It
> > would work if the futex key calculation was inside the loop.
>
> Sure, but that's still true: It's just that the get_user() is done twice
> instead. The semaphore is never released between the key calculation and
> the "real" get_user().

Ah, I didn't look at where the loop is used and didn't think there'd
be _two_ get_user() calls in the fast case. Not my instinct.

> > A much simpler solution (and sorry for not offering it earlier,
> > because Andrew Morton pointed out this bug long ago, but I was busy), is:
>
> Either way works for me. Andrew/Linus, got a preference? I'll either
> post my refresh based on Andrews comments, or code up Jamie's
> suggestion.

Yours has a couple of problems.

1. It'll make futex waits somewhat slower. One of the nicer features
of 2.6 futexes is that we got rid of the explicit page table lookup.

2. It's broken because a page can be paged out by another thread
after you've forced it in and before the get_user(). We only
take mmap_sem, not the page table lock.

-- Jamie