Re: [PATCH/RFC] Futex mmap_sem deadlock

Jamie Lokier
2005-02-22T21:28:13Z

Chris Friesen wrote:
> > down_read(&current->mm->mmap_sem);
> > get_futex_key(...) etc.
> > queue_me(...) etc.
> > current->flags |= PF_MMAP_SEM; <- new
> > ret = get_user(...);
> > current->flags &= PF_MMAP_SEM; <- new
> > /* the rest */
>
> Should the second new line be this (with the inverse)?
>
> current->flags &= ~PF_MMAP_SEM;

Quiet! I was trying to sneak in a security hole! :)

-- Jamie