From: Herbert Poetzl <herbert@13thfloor.at>
To: Ingo Oeser <ioe-lkml@axxeo.de>
Cc: Linux Kernel ML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Subject: Re: [Patch 4/6] Bind Mount Extensions 0.06
Date: Thu, 24 Feb 2005 22:22:23 +0100 [thread overview]
Message-ID: <20050224212223.GE4981@mail.13thfloor.at> (raw)
In-Reply-To: <200502230129.30225.ioe-lkml@axxeo.de>
On Wed, Feb 23, 2005 at 01:29:30AM +0100, Ingo Oeser wrote:
> Hi,
>
> Herbert Poetzl wrote:
> > +static inline int mnt_may_unlink(struct vfsmount *mnt, struct inode *dir,
> > struct dentry *child) { + if (!child->d_inode)
> > + return -ENOENT;
> > + if (MNT_IS_RDONLY(mnt))
> > + return -EROFS;
> > + return 0;
> > +}
>
> The argument "dir" is not used. Please remove it and fix the callers.
hmm, yes, just saw that the mnt_may*() functions
are not according to the 'current' coding style for
that section/file, so I'll rework that anyway ...
thanks a lot for the input,
Herbert
> Regards
>
> Ingo Oeser
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2005-02-24 21:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-22 12:12 [Patch 4/6] Bind Mount Extensions 0.06 Herbert Poetzl
2005-02-22 14:45 ` Trond Myklebust
2005-02-23 22:48 ` Herbert Poetzl
2005-02-26 18:38 ` Herbert Poetzl
2005-02-23 0:29 ` Ingo Oeser
2005-02-24 21:22 ` Herbert Poetzl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050224212223.GE4981@mail.13thfloor.at \
--to=herbert@13thfloor.at \
--cc=akpm@osdl.org \
--cc=ioe-lkml@axxeo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox