public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Mickey Stein <yekkim@pacbell.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [i2c]: Fix some gcc 4.0 compile failures and warnings
Date: Fri, 25 Feb 2005 12:07:46 -0800	[thread overview]
Message-ID: <20050225200746.GC25915@kroah.com> (raw)
In-Reply-To: <421CFFDC.90806@pacbell.net>

On Wed, Feb 23, 2005 at 02:12:44PM -0800, Mickey Stein wrote:
> From: Mickey Stein
> Versions:   linux-2.6.11-rc4-bk11, gcc4 (GCC) 4.0.0 20050217 (latest fc 
> rawhide from 19Feb DL)
> 
> gcc 4.0.x cvs seems to dislike "include/linux/i2c.h file" and others 
> due to a current gcc 4.0.x change having to do with
> array declarations.
> 
> Example error msg:   include/linux/i2c.h:{55,194} error: array type has 
> incomplete element type
> 
> A. Daplas has recently done a workaround for this on another header 
> file. A thread discussing this
> can be found by following the link below:
> 
> http://gcc.gnu.org/ml/gcc/2005-02/msg00053.html
> 
> The patch changes the array(struct i2c_msg) declaration used by 
> *i2c_transfer and *master_xfer
> from "struct i2c_msg msg[]" format to "struct i2c_msg *msg".
> 
> After some grepping, I came up with about a dozen files that used the 
> format disliked by gcc4 that're addressed by the attached patch.
> Tested on gcc 3.x & gcc 4.x by configuring kernel with all i2c switches 
> enabled as module, and saw no errors or warnings in i2c.
> 
> Signed-off-by: Mickey Stein <yekkim@pacbell.net>

Applied, thanks.

greg k-h


  parent reply	other threads:[~2005-02-25 20:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-23 22:12 [PATCH] [i2c]: Fix some gcc 4.0 compile failures and warnings Mickey Stein
2005-02-23 22:57 ` linux-os
2005-02-23 23:17   ` Greg KH
2005-02-25 20:07 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-03-04 20:36 [PATCH] I2C: Make i2c list terminators explicitely unsigned Greg KH
2005-03-04 20:36 ` [PATCH] I2C: Fix some gcc 4.0 compile failures and warnings Greg KH
2005-03-04 22:55   ` Mickey Stein
2005-03-04 23:02     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050225200746.GC25915@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yekkim@pacbell.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox