From: Adrian Bunk <bunk@stusta.de>
To: jmorris@redhat.com, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch] better CRYPTO_AES <-> CRYPTO_AES_586 dependencies
Date: Fri, 25 Feb 2005 22:46:13 +0100 [thread overview]
Message-ID: <20050225214613.GF3311@stusta.de> (raw)
2.6.11-rc4-mm1 contains an option (IEEE80211_CRYPT_CCMP) that selects
CRYPTO_AES - but this is currently wrong on i386.
This patch changes CRYPTO_AES to being the only user-visible options and
selecting either CRYPTO_AES_586 or a new CRYPTO_AES_GENERIC option
depending on the platform.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
BTW: Does CRYPTO_AES_586 work on an 386 or 486?
crypto/Kconfig | 26 +++++++-------------------
crypto/Makefile | 2 +-
2 files changed, 8 insertions(+), 20 deletions(-)
--- linux-2.6.11-rc4-mm1-full/crypto/Kconfig.old 2005-02-25 22:26:20.000000000 +0100
+++ linux-2.6.11-rc4-mm1-full/crypto/Kconfig 2005-02-25 22:28:44.000000000 +0100
@@ -133,7 +133,9 @@
config CRYPTO_AES
tristate "AES cipher algorithms"
- depends on CRYPTO && !(X86 && !X86_64)
+ depends on CRYPTO
+ select CRYPTO_AES_GENERIC if !(X86 && !X86_64)
+ select CRYPTO_AES_586 if (X86 && !X86_64)
help
AES cipher algorithms (FIPS-197). AES uses the Rijndael
algorithm.
@@ -151,25 +153,11 @@
See <http://csrc.nist.gov/CryptoToolkit/aes/> for more information.
-config CRYPTO_AES_586
- tristate "AES cipher algorithms (i586)"
- depends on CRYPTO && (X86 && !X86_64)
- help
- AES cipher algorithms (FIPS-197). AES uses the Rijndael
- algorithm.
+config CRYPTO_AES_GENERIC
+ tristate
- Rijndael appears to be consistently a very good performer in
- both hardware and software across a wide range of computing
- environments regardless of its use in feedback or non-feedback
- modes. Its key setup time is excellent, and its key agility is
- good. Rijndael's very low memory requirements make it very well
- suited for restricted-space environments, in which it also
- demonstrates excellent performance. Rijndael's operations are
- among the easiest to defend against power and timing attacks.
-
- The AES specifies three key sizes: 128, 192 and 256 bits
-
- See <http://csrc.nist.gov/encryption/aes/> for more information.
+config CRYPTO_AES_586
+ tristate
config CRYPTO_CAST5
tristate "CAST5 (CAST-128) cipher algorithm"
--- linux-2.6.11-rc4-mm1-full/crypto/Makefile.old 2005-02-25 22:29:33.000000000 +0100
+++ linux-2.6.11-rc4-mm1-full/crypto/Makefile 2005-02-25 22:29:42.000000000 +0100
@@ -19,7 +19,7 @@
obj-$(CONFIG_CRYPTO_BLOWFISH) += blowfish.o
obj-$(CONFIG_CRYPTO_TWOFISH) += twofish.o
obj-$(CONFIG_CRYPTO_SERPENT) += serpent.o
-obj-$(CONFIG_CRYPTO_AES) += aes.o
+obj-$(CONFIG_CRYPTO_AES_GENERIC) += aes.o
obj-$(CONFIG_CRYPTO_CAST5) += cast5.o
obj-$(CONFIG_CRYPTO_CAST6) += cast6.o
obj-$(CONFIG_CRYPTO_ARC4) += arc4.o
next reply other threads:[~2005-02-25 21:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-25 21:46 Adrian Bunk [this message]
2005-02-25 22:00 ` [2.6 patch] better CRYPTO_AES <-> CRYPTO_AES_586 dependencies James Morris
2005-02-25 22:08 ` Chris Friesen
2005-02-25 22:29 ` Adrian Bunk
2005-03-08 19:50 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050225214613.GF3311@stusta.de \
--to=bunk@stusta.de \
--cc=davem@davemloft.net \
--cc=jmorris@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox