From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] unexport do_settimeofday
Date: Sat, 26 Feb 2005 00:02:46 +0100 [thread overview]
Message-ID: <20050225230246.GI3311@stusta.de> (raw)
In-Reply-To: <20050225135504.7749942e.akpm@osdl.org>
On Fri, Feb 25, 2005 at 01:55:04PM -0800, Andrew Morton wrote:
>...
> --- 25/include/linux/compiler.h~a 2005-02-25 13:53:32.000000000 -0800
> +++ 25-akpm/include/linux/compiler.h 2005-02-25 13:54:45.000000000 -0800
> @@ -86,6 +86,12 @@ extern void __chk_io_ptr(void __iomem *)
> # define __deprecated /* unimplemented */
> #endif
>
> +#ifdef MODULE
> +#define __deprecated_in_modules __deprecated
> +#else
> +#define __deprecated_in_modules /* OK in non-modular code */
> +#endif
> +
>...
Looks good.
One more question:
You get a false positive if the file containing the symbol is itself a
module.
Is there any way to solve this without additional #define's and #ifdef's
for each symbol?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2005-02-25 23:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-24 23:37 [2.6 patch] unexport do_settimeofday Adrian Bunk
2005-02-25 5:24 ` Andrew Morton
2005-02-25 8:02 ` Arjan van de Ven
2005-02-25 8:28 ` Andrew Morton
2005-02-25 8:47 ` Bartlomiej Zolnierkiewicz
2005-02-25 9:26 ` Andreas Dilger
2005-02-25 9:33 ` Arjan van de Ven
2005-02-25 9:46 ` Andrew Morton
2005-02-27 22:44 ` Christoph Hellwig
2005-02-25 21:43 ` Adrian Bunk
2005-02-25 21:55 ` Andrew Morton
2005-02-25 23:02 ` Adrian Bunk [this message]
2005-02-25 23:20 ` Andrew Morton
2005-02-26 10:01 ` Arjan van de Ven
2005-02-26 15:28 ` Adrian Bunk
2005-02-26 15:22 ` Adrian Bunk
2005-02-26 13:33 ` [2.6 patch] deprecate EXPORT_SYMBOL(do_settimeofday) Adrian Bunk
2005-02-26 13:37 ` YOSHIFUJI Hideaki / 吉藤英明
2005-02-26 13:38 ` YOSHIFUJI Hideaki / 吉藤英明
2005-02-26 14:46 ` Russell King
2005-02-26 16:23 ` Adrian Bunk
2005-02-26 16:46 ` Russell King
2005-02-26 17:13 ` Adrian Bunk
2005-02-26 17:20 ` Russell King
2005-02-27 0:28 ` Adrian Bunk
2005-02-26 17:29 ` Russell King
2005-02-27 0:43 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050225230246.GI3311@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox