public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] deprecate EXPORT_SYMBOL(do_settimeofday)
Date: Sat, 26 Feb 2005 14:46:35 +0000	[thread overview]
Message-ID: <20050226144635.B7151@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20050226133337.GK3311@stusta.de>; from bunk@stusta.de on Sat, Feb 26, 2005 at 02:33:37PM +0100

On Sat, Feb 26, 2005 at 02:33:37PM +0100, Adrian Bunk wrote:
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Please don't deprecate this symbol.  ARM has a large variety of RTC
implementations, some of which reside in I2C modules which are yet
to be merged.

Firstly, these aren't accessible until the i2c subsystem has been
initialised.  Secondly, i2c is modular, so this function must be
accessible from a module in order for the system time/date to be
initialised from the RTC with a modular build.

(It can be argued that you wouldn't want to build such a thing as a
module in the first place, in which case removing the export would
of course be fine.  However, we can't sanely force I2C to be either
always builtin, and placing this expectation on people will eventually
lead other janitors to complain that the symbol is used by modules but
isn't exported.)

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core

  parent reply	other threads:[~2005-02-26 14:46 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-24 23:37 [2.6 patch] unexport do_settimeofday Adrian Bunk
2005-02-25  5:24 ` Andrew Morton
2005-02-25  8:02   ` Arjan van de Ven
2005-02-25  8:28     ` Andrew Morton
2005-02-25  8:47       ` Bartlomiej Zolnierkiewicz
2005-02-25  9:26         ` Andreas Dilger
2005-02-25  9:33           ` Arjan van de Ven
2005-02-25  9:46             ` Andrew Morton
2005-02-27 22:44       ` Christoph Hellwig
2005-02-25 21:43   ` Adrian Bunk
2005-02-25 21:55     ` Andrew Morton
2005-02-25 23:02       ` Adrian Bunk
2005-02-25 23:20         ` Andrew Morton
2005-02-26 10:01           ` Arjan van de Ven
2005-02-26 15:28             ` Adrian Bunk
2005-02-26 15:22           ` Adrian Bunk
2005-02-26 13:33   ` [2.6 patch] deprecate EXPORT_SYMBOL(do_settimeofday) Adrian Bunk
2005-02-26 13:37     ` YOSHIFUJI Hideaki / 吉藤英明
2005-02-26 13:38       ` YOSHIFUJI Hideaki / 吉藤英明
2005-02-26 14:46     ` Russell King [this message]
2005-02-26 16:23       ` Adrian Bunk
2005-02-26 16:46         ` Russell King
2005-02-26 17:13           ` Adrian Bunk
2005-02-26 17:20             ` Russell King
2005-02-27  0:28               ` Adrian Bunk
2005-02-26 17:29             ` Russell King
2005-02-27  0:43               ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050226144635.B7151@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox