From: Andries Brouwer <Andries.Brouwer@cwi.nl>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Uwe Bonnes <bon@elektron.ikp.physik.tu-darmstadt.de>,
Andries Brouwer <Andries.Brouwer@cwi.nl>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] partitions/msdos.c
Date: Sat, 26 Feb 2005 23:52:03 +0100 [thread overview]
Message-ID: <20050226225203.GA25217@apps.cwi.nl> (raw)
In-Reply-To: <Pine.LNX.4.58.0502261424430.25732@ppc970.osdl.org>
On Sat, Feb 26, 2005 at 02:28:45PM -0800, Linus Torvalds wrote:
> Would it not make more sense to just sanity-check the size itself, and
> throw it out if the partition size (plus start) is bigger than the disk
> size?
I don't mind.
> There might well be people use use partition type 0, just because they
> just never _set_ the partition type.. I don't think Linux has ever cared
> about any type except for the "extended partition" type, so checking for
> zero doesn't seem very safe..
The default fdisk will assign type 83 to a newly created partition.
One has to change it by hand to 0. So, I do not think testing against 0
is so bad. A heuristic, You give another heuristic. Probably there will
be a point in time where we need both.
(About type 0: DOS has used type 0 as definition of unused. It is not
bad if Linux uses DOS-conventions for a DOS-type partition table.)
Andries
next prev parent reply other threads:[~2005-02-26 22:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-26 21:35 [PATCH] partitions/msdos.c Andries Brouwer
2005-02-26 22:04 ` Uwe Bonnes
2005-02-26 22:28 ` Linus Torvalds
2005-02-26 22:35 ` Linus Torvalds
2005-02-26 23:24 ` Uwe Bonnes
2005-02-26 23:46 ` Linus Torvalds
2005-02-26 23:53 ` Andries Brouwer
2005-02-26 22:52 ` Andries Brouwer [this message]
2005-02-26 23:12 ` Linus Torvalds
2005-02-26 23:40 ` Andries Brouwer
2005-02-26 23:49 ` Linus Torvalds
2005-02-27 0:47 ` Uwe Bonnes
2005-02-27 1:04 ` Linus Torvalds
2005-02-27 14:33 ` Uwe Bonnes
2005-02-27 1:07 ` Andries Brouwer
2005-03-01 6:53 ` Rogier Wolff
2005-03-19 21:54 ` Werner Almesberger
2005-03-19 22:28 ` Grzegorz Kulewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050226225203.GA25217@apps.cwi.nl \
--to=andries.brouwer@cwi.nl \
--cc=akpm@osdl.org \
--cc=bon@elektron.ikp.physik.tu-darmstadt.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox