From: Alexey Dobriyan <adobriyan@mail.ru>
To: Eric Gaumer <gaumerel@ecs.fullerton.edu>
Cc: linux-kernel@vger.kernel.org, proski@gnu.org,
hermes@gibson.dropbear.id.au
Subject: Re: [PATCH] orinoco rfmon
Date: Sat, 26 Feb 2005 22:59:30 +0200 [thread overview]
Message-ID: <200502262259.30897.adobriyan@mail.ru> (raw)
In-Reply-To: <4220BB87.2010806@ecs.fullerton.edu>
On Saturday 26 February 2005 20:10, Eric Gaumer wrote:
> If the code looks problematic could someone point out possible
> deficiencies so we can work toward a satisfactory resolution? I didn't
> write the code but I'm willing do what I have to in order to get this
> (wireless scanning) into the official tree.
Uhhh... Started to comment line-by-line but then realized it would take too
much time.
* Read Documentaion/CodingStyle.
* Indent code with tabs where it is already indented with tabs.
* Brackets around a single number in #define's are useless.
* Use u8, u16, u32 (not uint*_t) where the code already uses them.
* Comments are supposed to be anonymous.
* Use appropriate KERN_* constant in printk()'s.
* Don't pack simple types (uint32_t, ...)
* Common convention is to return 0 on success, negative number on error.
Positive return values don't fit well into this scheme. If possible
follow it.
Oh, and the type p80211item_uint32_t when in fact it is a 12-bytes long
structure ...
Alexey
next prev parent reply other threads:[~2005-02-26 19:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-26 18:10 [PATCH] orinoco rfmon Eric Gaumer
2005-02-26 20:59 ` Alexey Dobriyan [this message]
2005-02-26 22:45 ` Eric Gaumer
2005-02-28 7:44 ` Greg KH
2005-02-28 7:48 ` Eric Gaumer
2005-02-27 3:39 ` David Gibson
2005-02-28 0:45 ` Eric Gaumer
2005-02-28 0:54 ` David Gibson
2005-02-28 20:01 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200502262259.30897.adobriyan@mail.ru \
--to=adobriyan@mail.ru \
--cc=gaumerel@ecs.fullerton.edu \
--cc=hermes@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox