Re: [patch 3/2] drivers/char/vt.c: remove unnecessary code

Adrian Bunk
2005-02-28T13:33:17Z

On Mon, Feb 28, 2005 at 02:13:57PM +0100, colbuse@ensisun.imag.fr wrote:
>
> >On Mon, Feb 28, 2005 at 01:57:59PM +0100, colbuse@xxxxxxxxxxxxxxx wrote:
> >> Please _don't_ apply this, but tell me what you think about it.
>
> >It's broken. 8)
>
> >> --- old/drivers/char/vt.c 2004-12-24 22:35:25.000000000 +0100
> >> +++ new/drivers/char/vt.c 2005-02-28 12:53:57.933256631 +0100
> >> @@ -1655,9 +1655,9 @@
> >> vc_state = ESnormal;
> >> return;
> >> case ESsquare:
> >> - for(npar = 0 ; npar < NPAR ; npar++)
> >> + for(npar = NPAR-1; npar < NPAR; npar--)
>
> >How many times do you want this for loop to run?
>
>
> NPAR times :-). As I stated, npar is unsigned.
>...

The Linux kernel is not the obfuscated C contest.

Your code might be technically correct, but your patch changes a
perfectly readable line into an unreadable line for no gain.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed