Re: [patch 3/2] drivers/char/vt.c: remove unnecessary code

Russell King
2005-02-28T13:02:45Z

On Mon, Feb 28, 2005 at 01:57:59PM +0100, colbuse@ensisun.imag.fr wrote:
> Please _don't_ apply this, but tell me what you think about it.

It's broken. 8)

> --- old/drivers/char/vt.c 2004-12-24 22:35:25.000000000 +0100
> +++ new/drivers/char/vt.c 2005-02-28 12:53:57.933256631 +0100
> @@ -1655,9 +1655,9 @@
> vc_state = ESnormal;
> return;
> case ESsquare:
> - for(npar = 0 ; npar < NPAR ; npar++)
> + for(npar = NPAR-1; npar < NPAR; npar--)

How many times do you want this for loop to run?

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core