Re: [patch 3/2] drivers/char/vt.c: remove unnecessary code

Dmitry Torokhov
2005-02-28T14:09:31Z

On Mon, 28 Feb 2005 15:02:32 +0100, Arjan van de Ven
<arjan@infradead.org> wrote:
> \
> > > >> + for(npar = NPAR-1; npar < NPAR; npar--)
> > >
> > > >How many times do you want this for loop to run?
> > >
> > > NPAR times :-). As I stated, npar is unsigned.
> > >
> >
> > for (npar = NPAR - 1; npar >= 0; npar--)
> >
> > would be more readable and may be even faster on a dumb compiler than
> > your variant. Still, I'd have compiler worry about such
> > micro-optimizations.
>
> actually that goes wrong for npar unsigned...
>
>

Oops, you are right...

--
Dmitry