Re: [PATCH] remove dead cyrix/centaur mtrr init code

Andries Brouwer
2005-03-09T19:11:50Z

On Wed, Mar 09, 2005 at 04:55:27PM +0000, Alan Cox wrote:

> > [PATCH] remove dead cyrix/centaur mtrr init code
>
> This patch was discussed previously and declared incorrect. The ->init
> method call is missing in the base mtrr code.
>
> Should be reverted and/or fixed properly.

Hi Alan - a surprising reaction.

The patch is an improvement - it #ifdef's out some dead code.
I sent you a follow-up patch that activates the dead code,
since you said

I have one here running 2.4 still. I can test a 2.6 fix
for the mtrr init happily enough.

But so far you have not replied.
The moment you report that the follow-up patch is fine, we can
remove the #if 0 and insert the initcalls instead.

So, all is well today, and we are waiting for your report.

Andries