Re: [PATCH] remove dead cyrix/centaur mtrr init code

Dave Jones
2005-03-02T08:03:12Z

On Wed, Mar 02, 2005 at 08:50:38AM +0100, Andries Brouwer wrote:
> On Tue, Mar 01, 2005 at 11:52:44PM +0000, Alan Cox wrote:
> > On Llu, 2005-02-28 at 19:20, Andries Brouwer wrote:
> > > One such case is the mtrr code, where struct mtrr_ops has an
> > > init field pointing at __init functions. Unless I overlook
> > > something, this case may be easy to settle, since the .init
> > > field is never used.
> >
> > The failure to invoke the ->init operator appears to be the bug.
> > The centaur code definitely wants the mcr init function to be called.
>
> Yes, I expected that to be the answer. Therefore #if 0 instead of deleting.
> But if calling ->init() is needed, and it has not been done the past
> three years, the question arises whether there are any users.

The Winchips never really sold that well, and stopped being produced
when IDT sold off Centaur. It was a niche processor in 1997. In 2005,
I'll be surprised if there are that many of them still working.
Mine lost its magic smoke for no reason around ~2002.

If there are any of them still being used out there, I'd be even
more surprised if they're running 2.6. Then again, there are
probably loonies out there running it on 386/486's. 8-)

Dave