From: Pavel Machek <pavel@suse.cz>
To: Greg KH <greg@kroah.com>
Cc: Andrew Morton <akpm@zip.com.au>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: Fix few remaining u32 vs. pm_message_t issues
Date: Mon, 28 Feb 2005 23:19:04 +0100 [thread overview]
Message-ID: <20050228221904.GI1615@elf.ucw.cz> (raw)
In-Reply-To: <20050228205251.GA22844@kroah.com>
Hi!
> > -mm is pretty good in u32 vs. pm_message_t area, there are only few
> > -places missing. Some of them are in usb (and already on their way
> > -through greg), this should fix the rest. Only code change is
> > -pci_choose_state in savagefb. Please apply,
>
> If you split out the drivers/base/* and the drivers/pci/* ones I'll add
> those to my trees too.
Okay, here they are:
Thanks,
Pavel
--- clean-mm/drivers/base/power/runtime.c 2005-01-12 11:07:39.000000000 +0100
+++ linux-mm/drivers/base/power/runtime.c 2005-02-28 21:05:15.000000000 +0100
@@ -16,7 +16,7 @@
if (!dev->power.power_state)
return;
if (!resume_device(dev))
- dev->power.power_state = 0;
+ dev->power.power_state = PMSG_ON;
}
--- clean-mm/drivers/base/power/sysfs.c 2004-08-15 19:14:55.000000000 +0200
+++ linux-mm/drivers/base/power/sysfs.c 2005-02-28 21:05:15.000000000 +0100
@@ -31,7 +31,7 @@
static ssize_t state_store(struct device * dev, const char * buf, size_t n)
{
- u32 state;
+ pm_message_t state;
char * rest;
int error = 0;
--- clean-mm/drivers/pci/pci.c 2005-02-28 01:13:58.000000000 +0100
+++ linux-mm/drivers/pci/pci.c 2005-02-28 21:05:55.000000000 +0100
@@ -312,13 +312,14 @@
/**
* pci_choose_state - Choose the power state of a PCI device
* @dev: PCI device to be suspended
- * @state: target sleep state for the whole system
+ * @state: target sleep state for the whole system. This is the value
+ * that is passed to suspend() function.
*
* Returns PCI power state suitable for given device and given system
* message.
*/
-pci_power_t pci_choose_state(struct pci_dev *dev, u32 state)
+pci_power_t pci_choose_state(struct pci_dev *dev, pm_message_t state)
{
if (!pci_find_capability(dev, PCI_CAP_ID_PM))
return PCI_D0;
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
prev parent reply other threads:[~2005-02-28 22:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-28 20:15 Fix few remaining u32 vs. pm_message_t issues Pavel Machek
2005-02-28 20:52 ` Greg KH
2005-02-28 22:19 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050228221904.GI1615@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=akpm@zip.com.au \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox