From: Greg KH <greg@kroah.com>
To: James Chapman <jchapman@katalix.com>
Cc: sensors@Stimpy.netroedge.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH: 2.6.11-rc5] i2c chips: ds1337 RTC driver
Date: Mon, 28 Feb 2005 23:54:13 -0800 [thread overview]
Message-ID: <20050301075413.GC3791@kroah.com> (raw)
In-Reply-To: <42235171.80500@katalix.com>
On Mon, Feb 28, 2005 at 05:14:25PM +0000, James Chapman wrote:
> +/* Define to compile in pr_debug() trace */
> +#undef DEBUG
Not needed, we do this in the makefile now.
> + if (debug >= 1)
> + pr_debug("%s: client=%p, dt=%p\n", __FUNCTION__, client, dt);
Please use the dev_dbg(), dev_err() and friend functions instead of
pr_debug(). It provides a sane user interface that all of the other
drivers use.
thanks,
greg k-h
next prev parent reply other threads:[~2005-03-01 8:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-28 17:14 [PATCH: 2.6.11-rc5] i2c chips: ds1337 RTC driver James Chapman
2005-03-01 7:54 ` Greg KH [this message]
2005-03-01 19:21 ` James Chapman
2005-03-02 9:43 ` Jean Delvare
2005-03-02 18:45 ` [PATCH 2.6] Trivial indentation fix in i2c/chips/Kconfig Jean Delvare
2005-03-03 0:14 ` Greg KH
2005-03-03 17:23 ` [PATCH: 2.6.11-rc5] i2c chips: ds1337 RTC driver James Chapman
2005-03-03 19:49 ` Jean Delvare
2005-03-04 0:08 ` James Chapman
2005-03-04 8:45 ` Jean Delvare
2005-03-02 16:59 ` Greg KH
2005-03-03 5:04 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050301075413.GC3791@kroah.com \
--to=greg@kroah.com \
--cc=jchapman@katalix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@Stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox