* [PATCH] SELinux: null dereference in error path
@ 2005-03-01 0:32 Alexander Nyberg
2005-03-01 4:11 ` James Morris
2005-03-01 15:05 ` Stephen Smalley
0 siblings, 2 replies; 6+ messages in thread
From: Alexander Nyberg @ 2005-03-01 0:32 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, jmorris, sds
The 'bad' label will call function that unconditionally dereferences
the NULL pointer.
Found by the Coverity tool
Signed-off-by: Alexander Nyberg <alexn@dsv.su.se>
===== security/selinux/ss/policydb.c 1.16 vs edited =====
--- 1.16/security/selinux/ss/policydb.c 2005-01-15 23:01:45 +01:00
+++ edited/security/selinux/ss/policydb.c 2005-02-26 12:47:44 +01:00
@@ -773,7 +773,7 @@ static int class_read(struct policydb *p
cladatum = kmalloc(sizeof(*cladatum), GFP_KERNEL);
if (!cladatum) {
rc = -ENOMEM;
- goto bad;
+ goto out;
}
memset(cladatum, 0, sizeof(*cladatum));
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] SELinux: null dereference in error path
2005-03-01 0:32 [PATCH] SELinux: null dereference in error path Alexander Nyberg
@ 2005-03-01 4:11 ` James Morris
2005-03-01 4:25 ` Kyle Moffett
2005-03-01 15:05 ` Stephen Smalley
1 sibling, 1 reply; 6+ messages in thread
From: James Morris @ 2005-03-01 4:11 UTC (permalink / raw)
To: Alexander Nyberg; +Cc: akpm, linux-kernel, sds
On Tue, 1 Mar 2005, Alexander Nyberg wrote:
> The 'bad' label will call function that unconditionally dereferences
> the NULL pointer.
>
> Found by the Coverity tool
>
> Signed-off-by: Alexander Nyberg <alexn@dsv.su.se>
Signed-off-by: James Morris <jmorris@redhat.com>
--
James Morris
<jmorris@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] SELinux: null dereference in error path
2005-03-01 4:11 ` James Morris
@ 2005-03-01 4:25 ` Kyle Moffett
2005-03-01 4:31 ` Andrew Morton
2005-03-01 16:26 ` Folkert van Heusden
0 siblings, 2 replies; 6+ messages in thread
From: Kyle Moffett @ 2005-03-01 4:25 UTC (permalink / raw)
To: James Morris; +Cc: lkml Mailing List, Andrew Morton, sds, Alexander Nyberg
On Feb 28, 2005, at 23:11, James Morris wrote:
> On Tue, 1 Mar 2005, Alexander Nyberg wrote:
>
>> The 'bad' label will call function that unconditionally dereferences
>> the NULL pointer.
>>
>> Found by the Coverity tool
>>
>> Signed-off-by: Alexander Nyberg <alexn@dsv.su.se>
>
> Signed-off-by: James Morris <jmorris@redhat.com>
Err, isn't it "Acked-by:"?? I thought "Signed-off-by:" was only for
when
the patch actually went through someone's tree and was forwarded by them
to somebody else:
EG:
John Doe writes a patch that fixes a NULL pointer deref, and he sends it
to Andrew Morton. The maintainer of the driver, Jane McDonald, confirms
the fix via email to this list. Andrew forwards it to Linus, who
includes it in his next release. The resulting notations look like
this:
Signed-off-by: John Doe
Acked-by: Jane McDonald
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
Cheers,
Kyle Moffett
-----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GCM/CS/IT/U d- s++: a18 C++++>$ UB/L/X/*++++(+)>$ P+++(++++)>$
L++++(+++) E W++(+) N+++(++) o? K? w--- O? M++ V? PS+() PE+(-) Y+
PGP+++ t+(+++) 5 X R? tv-(--) b++++(++) DI+ D+ G e->++++$ h!*()>++$ r
!y?(-)
------END GEEK CODE BLOCK------
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] SELinux: null dereference in error path
2005-03-01 4:25 ` Kyle Moffett
@ 2005-03-01 4:31 ` Andrew Morton
2005-03-01 16:26 ` Folkert van Heusden
1 sibling, 0 replies; 6+ messages in thread
From: Andrew Morton @ 2005-03-01 4:31 UTC (permalink / raw)
To: Kyle Moffett; +Cc: jmorris, linux-kernel, sds, alexn
Kyle Moffett <mrmacman_g4@mac.com> wrote:
>
> Err, isn't it "Acked-by:"??
Yes, I usually change it to Acked-by when it's obvious.
Signed-off-by: "I worked on this patch"
Acked-by: "Looks good"
Tested-by: "You're kidding"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] SELinux: null dereference in error path
2005-03-01 4:25 ` Kyle Moffett
2005-03-01 4:31 ` Andrew Morton
@ 2005-03-01 16:26 ` Folkert van Heusden
1 sibling, 0 replies; 6+ messages in thread
From: Folkert van Heusden @ 2005-03-01 16:26 UTC (permalink / raw)
To: Kyle Moffett
Cc: James Morris, lkml Mailing List, Andrew Morton, sds,
Alexander Nyberg
[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]
> >>The 'bad' label will call function that unconditionally dereferences
> >>the NULL pointer.
> >>Found by the Coverity tool
> >>Signed-off-by: Alexander Nyberg <alexn@dsv.su.se>
> >Signed-off-by: James Morris <jmorris@redhat.com>
> Err, isn't it "Acked-by:"?? I thought "Signed-off-by:" was only for
> when
> the patch actually went through someone's tree and was forwarded by them
> to somebody else:
Isn't also a good idea to sign your message with gpg or so? That way one
is 100% sure that it *is* that person who is signing-off or acking-by.
Folkert van Heusden
Op zoek naar een IT of Finance baan? Mail me voor de mogelijkheden!
+------------------------------------------------------------------+
|UNIX admin? Then give MultiTail (http://vanheusden.com/multitail/)|
|a try, it brings monitoring logfiles to a different level! See |
|http://vanheusden.com/multitail/features.html for a feature list. |
+------------------------------------------= www.unixsoftware.nl =-+
Phone: +31-6-41278122, PGP-key: 1F28D8AE
Get your PGP/GPG key signed at www.biglumber.com!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] SELinux: null dereference in error path
2005-03-01 0:32 [PATCH] SELinux: null dereference in error path Alexander Nyberg
2005-03-01 4:11 ` James Morris
@ 2005-03-01 15:05 ` Stephen Smalley
1 sibling, 0 replies; 6+ messages in thread
From: Stephen Smalley @ 2005-03-01 15:05 UTC (permalink / raw)
To: Alexander Nyberg; +Cc: akpm, linux-kernel, jmorris
On Tue, 2005-03-01 at 01:32 +0100, Alexander Nyberg wrote:
> The 'bad' label will call function that unconditionally dereferences
> the NULL pointer.
>
> Found by the Coverity tool
>
> Signed-off-by: Alexander Nyberg <alexn@dsv.su.se>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
--
Stephen Smalley <sds@epoch.ncsc.mil>
National Security Agency
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-03-01 16:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-01 0:32 [PATCH] SELinux: null dereference in error path Alexander Nyberg
2005-03-01 4:11 ` James Morris
2005-03-01 4:25 ` Kyle Moffett
2005-03-01 4:31 ` Andrew Morton
2005-03-01 16:26 ` Folkert van Heusden
2005-03-01 15:05 ` Stephen Smalley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox