From: Dave Jones <davej@redhat.com>
To: Andries Brouwer <Andries.Brouwer@cwi.nl>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
torvalds@osdl.org, akpm@osdl.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] remove dead cyrix/centaur mtrr init code
Date: Wed, 2 Mar 2005 03:02:55 -0500 [thread overview]
Message-ID: <20050302080255.GA28512@redhat.com> (raw)
In-Reply-To: <20050302075037.GH20190@apps.cwi.nl>
On Wed, Mar 02, 2005 at 08:50:38AM +0100, Andries Brouwer wrote:
> On Tue, Mar 01, 2005 at 11:52:44PM +0000, Alan Cox wrote:
> > On Llu, 2005-02-28 at 19:20, Andries Brouwer wrote:
> > > One such case is the mtrr code, where struct mtrr_ops has an
> > > init field pointing at __init functions. Unless I overlook
> > > something, this case may be easy to settle, since the .init
> > > field is never used.
> >
> > The failure to invoke the ->init operator appears to be the bug.
> > The centaur code definitely wants the mcr init function to be called.
>
> Yes, I expected that to be the answer. Therefore #if 0 instead of deleting.
> But if calling ->init() is needed, and it has not been done the past
> three years, the question arises whether there are any users.
The Winchips never really sold that well, and stopped being produced
when IDT sold off Centaur. It was a niche processor in 1997. In 2005,
I'll be surprised if there are that many of them still working.
Mine lost its magic smoke for no reason around ~2002.
If there are any of them still being used out there, I'd be even
more surprised if they're running 2.6. Then again, there are
probably loonies out there running it on 386/486's. 8-)
Dave
next prev parent reply other threads:[~2005-03-02 8:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-28 19:20 [PATCH] remove dead cyrix/centaur mtrr init code Andries Brouwer
2005-02-28 19:35 ` Adrian Bunk
2005-02-28 21:51 ` Andries Brouwer
2005-03-01 23:52 ` Alan Cox
2005-03-02 7:50 ` Andries Brouwer
2005-03-02 8:02 ` Dave Jones [this message]
2005-03-02 13:45 ` Alan Cox
2005-03-02 22:21 ` Andries Brouwer
2005-03-02 22:28 ` Dave Jones
2005-03-03 12:02 ` Alan Cox
2005-03-02 19:14 ` Nuno Monteiro
2005-03-02 14:59 ` Ondrej Zary
2005-03-02 19:18 ` Dave Jones
2005-03-02 21:30 ` Ondrej Zary
[not found] <200503081937.j28Jb4Vd020597@hera.kernel.org>
2005-03-09 16:55 ` Alan Cox
2005-03-09 17:09 ` Linus Torvalds
2005-03-09 18:23 ` Alan Cox
2005-03-09 19:09 ` Andries Brouwer
2005-03-09 20:36 ` Alan Cox
2005-03-14 17:38 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050302080255.GA28512@redhat.com \
--to=davej@redhat.com \
--cc=Andries.Brouwer@cwi.nl \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox