From: Andrew Morton <akpm@osdl.org>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: linux-kernel@vger.kernel.org, linuxram@us.ibm.com,
slpratt@austin.ibm.com
Subject: Re: [PATCH 1/2] readahead: simplify ra->size testing
Date: Wed, 2 Mar 2005 17:59:47 -0800 [thread overview]
Message-ID: <20050302175947.6f1e6b5f.akpm@osdl.org> (raw)
In-Reply-To: <42260F2C.FCAA1915@tv-sign.ru>
Oleg Nesterov <oleg@tv-sign.ru> wrote:
>
> On top of "readahead: cleanup blockable_page_cache_readahead()",
> see http://marc.theaimsgroup.com/?l=linux-kernel&m=110927049500942
>
> Currently page_cache_readahead() treats ra->size == 0 (first read)
> and ra->size == -1 (ra_off was called) separately, but does exactly
> the same in both cases.
>
> With this patch we may assume that the reading starts in 'ra_off()'
> state, so we don't need to consider the first read as a special case.
So... the big "how it all works" comment needs an update..
next prev parent reply other threads:[~2005-03-03 2:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-02 19:08 [PATCH 1/2] readahead: simplify ra->size testing Oleg Nesterov
2005-03-03 1:59 ` Andrew Morton [this message]
2005-03-03 10:08 ` Oleg Nesterov
2005-03-03 9:28 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050302175947.6f1e6b5f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=oleg@tv-sign.ru \
--cc=slpratt@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox