public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: Page fault scalability patch V18: Drop first acquisition of ptl
Date: Wed, 2 Mar 2005 21:37:35 -0800	[thread overview]
Message-ID: <20050302213735.65be2db1.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0503022110280.4083@schroedinger.engr.sgi.com>

Christoph Lameter <clameter@sgi.com> wrote:
>
> On Wed, 2 Mar 2005, Andrew Morton wrote:
> 
> > Have the ppc64 and sparc64 people reviewed and acked the change?  (Not a
> > facetious question - I just haven't been following the saga sufficiently
> > closely to remember).
> 
> There should be no change to these arches

But we must at least confirm that these architectures can make these
changes in the future.  If they make no changes then they haven't
benefitted from the patch.  And the patch must be suitable for all
architectures which might hit this scalability problem.

> > > Because if a pte is locked it should not be used.
> >
> > Confused.  Why not just spin on the lock in the normal manner?
> 
> I thought you wanted to lock the pte? This is realized through a lock bit
> in the pte. If that lock bit is set one should not use the pte. Otherwise
> the lock is bypassed. Or are you proposing a write lock only?

I was suggesting a lock in (or associated with) the pageframe of the page
which holds the pte.  That's just a convenient way of hashing the locking. 
Probably that's not much different from the atomic pte ops.

> > If the other relvant architecture people say "we can use this" then perhaps
> > we should grin and bear it.  But one does wonder whether some more sweeping
> > design change is needed.
> 
> Could we at least get the first two patches in? I can then gradually
> address the other issues piece by piece.

The atomic ops patch should be coupled with the main patch series.  The mm
counter one we could sneak in beforehand, I guess.

> The necessary more sweeping design change can be found at
> 
> http://marc.theaimsgroup.com/?l=linux-kernel&m=110922543030922&w=2
> 
> but these may be a long way off.

Yes, that seemed sensible, although it may not work out to be as clean as
it appears.

But how would that work allow us to address page_table_lock scalability
problems?

  reply	other threads:[~2005-03-03  5:45 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-02  3:49 Page fault scalability patch V18: Overview Christoph Lameter
2005-03-02  3:50 ` Page fault scalability patch V18: atomic pte ops, pte_cmpxchg and pte_xchg Christoph Lameter
2005-03-02  3:51 ` Page fault scalability patch V18: abstract rss counter ops Christoph Lameter
2005-03-02  3:51 ` Page fault scalability patch V18: Drop first acquisition of ptl Christoph Lameter
2005-03-03  1:45   ` Andrew Morton
2005-03-03  2:13     ` Christoph Lameter
2005-03-03  2:55       ` Andrew Morton
2005-03-03  3:17         ` Christoph Lameter
2005-03-03  4:14           ` Andrew Morton
2005-03-03  4:27             ` Christoph Lameter
2005-03-03  4:56               ` Andrew Morton
2005-03-03  5:17                 ` Christoph Lameter
2005-03-03  5:37                   ` Andrew Morton [this message]
2005-03-03  5:48                     ` Christoph Lameter
2005-03-03  6:13                 ` Christoph Lameter
2005-03-03  6:20                   ` Andrew Morton
2005-03-03 16:54                     ` Christoph Lameter
2005-03-03 21:20                       ` Andrew Morton
2005-03-03 22:14                         ` Christoph Lameter
2005-03-04 16:44                         ` Christoph Lameter
2005-03-04 17:09                           ` Hugh Dickins
2005-03-04 18:29                             ` Christoph Lameter
2005-03-04 19:08                               ` Hugh Dickins
2005-03-31  6:55                             ` Avoid spurious page faults by avoiding pte_clear -> set pte Christoph Lameter
2005-03-04 16:46                         ` Page fault scalability patch V18: Drop first acquisition of ptl Christoph Lameter
2005-03-03  5:00             ` Paul Mackerras
2005-03-03  5:19               ` Christoph Lameter
2005-03-03  5:38               ` David S. Miller
2005-03-03  5:51                 ` Christoph Lameter
2005-03-03  6:11                   ` Benjamin Herrenschmidt
2005-03-03 16:52                     ` Christoph Lameter
2005-03-03  5:54                 ` Benjamin Herrenschmidt
2005-03-03 17:19                   ` Nick Piggin
2005-03-03  6:30                     ` Benjamin Herrenschmidt
2005-03-03  7:44                       ` Nick Piggin
2005-03-03 17:43                       ` David S. Miller
2005-03-03  5:24             ` Nick Piggin
2005-03-02  3:52 ` Page fault scalability patch V18: No page table lock in do_anonymous_page Christoph Lameter
2005-03-04  2:18 ` Page fault scalability patch V18: Overview Darren Williams
2005-03-04  2:47   ` Darren Williams
2005-03-04 16:15     ` Christoph Lameter
2005-03-06 21:49       ` Darren Williams
2005-03-06 23:59         ` Christoph Lameter
2005-03-07  3:32           ` Darren Williams
2005-03-08  4:03             ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050302213735.65be2db1.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=clameter@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox