Re: [PATCH] trivial fix for 2.6.11 raid6 compilation on ppc w/ Altivec

Greg KH
2005-03-03T22:53:45Z

On Fri, Mar 04, 2005 at 09:30:22AM +1100, Paul Mackerras wrote:
> Jeff Garzik writes:
> > Rene Rebe wrote:
> > > Hi,
> > >
> > >
> > > --- linux-2.6.11/drivers/md/raid6altivec.uc.vanilla 2005-03-02
> > > 16:44:56.407107752 +0100
> > > +++ linux-2.6.11/drivers/md/raid6altivec.uc 2005-03-02
> > > 16:45:22.424152560 +0100
> > > @@ -108,7 +108,7 @@
> > > int raid6_have_altivec(void)
> > > {
> > > /* This assumes either all CPUs have Altivec or none does */
> > > - return cur_cpu_spec->cpu_features & CPU_FTR_ALTIVEC;
> > > + return cur_cpu_spec[0]->cpu_features & CPU_FTR_ALTIVEC;
> >
> >
> > I nominate this as a candidate for linux-2.6.11 release branch. :)
>
> No. Unfortunately if you fix ppc64 here you will break ppc, and vice
> versa. Yes, we are going to reconcile the cur_cpu_spec definitions
> between ppc and ppc64. :)

Fine, dueling arches, who wins? :)

So, what do I do, just ignore the patch? Or do you have a fix?

thanks,

greg k-h