Re: [PATCH] trivial fix for 2.6.11 raid6 compilation on ppc w/ Altivec

Chris Wright
2005-03-04T06:49:56Z

* Andrew Morton (akpm@osdl.org) wrote:
> Chris Wright <chrisw@osdl.org> wrote:
> >
> > * Jeff Garzik (jgarzik@pobox.com) wrote:
> > > Andrew Morton wrote:
> > > >Chris Wright <chrisw@osdl.org> wrote:
> > > >>Olof's patch is in the linux-release tree, so this brings up a point
> > > >>regarding merging. If the quick fix is to be replaced by a better fix
> > > >>later (as in this case) there's some room for merge conflict. Does this
> > > >>pose a problem for either -mm or Linus' tree?
> > > >
> > > >It depends who gets to Linus's tree first. If linux-release merges first,
> > > >I just revert the temp fix while adding the real fix. But the temp fix
> > > >should never have gone into Linus's tree in the first place.
> >
> > Consider it first patch in fixup series ;-)

Actually I meant fix 1/2 == quick, fix 2/2 == more complete.

> Here's the second, and this is much more critical.
>
> And it's untested.

I'd rather it be tested.../me keeps wishing
If it's untested, are we even sure it fixes the problem? Or are you
worried about the umpteen other non-Dell laptops that could have
problems with the patch?

> And it's a temp-fix - it'll be addressed by other means in 2.6.12.
>
> What do we do?

IMO, we have to rely on Dmitry's judgement. Is it critical (i.e. broke
laptops how)? Can it be worked around with the i8042.noacpi boot param?
If so, I don't think it fits the bill as critical.

thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net