public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Paul Mackerras <paulus@samba.org>
Cc: Jeff Garzik <jgarzik@pobox.com>, Rene Rebe <rene@exactcode.de>,
	torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trivial fix for 2.6.11 raid6 compilation on ppc w/ Altivec
Date: Thu, 3 Mar 2005 14:45:15 -0800	[thread overview]
Message-ID: <20050303224515.GA16567@kroah.com> (raw)
In-Reply-To: <16935.36862.137151.499468@cargo.ozlabs.ibm.com>

On Fri, Mar 04, 2005 at 09:30:22AM +1100, Paul Mackerras wrote:
> Jeff Garzik writes:
> > Rene Rebe wrote:
> > > Hi,
> > > 
> > > 
> > > --- linux-2.6.11/drivers/md/raid6altivec.uc.vanilla    2005-03-02 
> > > 16:44:56.407107752 +0100
> > > +++ linux-2.6.11/drivers/md/raid6altivec.uc    2005-03-02 
> > > 16:45:22.424152560 +0100
> > > @@ -108,7 +108,7 @@
> > >  int raid6_have_altivec(void)
> > >  {
> > >      /* This assumes either all CPUs have Altivec or none does */
> > > -    return cur_cpu_spec->cpu_features & CPU_FTR_ALTIVEC;
> > > +    return cur_cpu_spec[0]->cpu_features & CPU_FTR_ALTIVEC;
> > 
> > 
> > I nominate this as a candidate for linux-2.6.11 release branch.  :)
> 
> No.  Unfortunately if you fix ppc64 here you will break ppc, and vice
> versa.  Yes, we are going to reconcile the cur_cpu_spec definitions
> between ppc and ppc64. :)

Fine, dueling arches, who wins?  :)

So, what do I do, just ignore the patch?  Or do you have a fix?

thanks,

greg k-h

  reply	other threads:[~2005-03-03 22:53 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-03 18:05 [PATCH] trivial fix for 2.6.11 raid6 compilation on ppc w/ Altivec Rene Rebe
2005-03-03 18:26 ` Jeff Garzik
2005-03-03 18:48   ` Greg KH
2005-03-03 18:59     ` Rene Rebe
2005-03-03 19:18   ` Greg KH
2005-03-03 19:48     ` Jeff Garzik
2005-03-03 20:07       ` Chris Wright
2005-03-03 20:32         ` Greg KH
2005-03-03 20:57           ` Jeff Garzik
2005-03-04 12:10             ` Francois Romieu
2005-03-03 22:30   ` Paul Mackerras
2005-03-03 22:45     ` Greg KH [this message]
2005-03-03 23:05       ` Dave Jones
2005-03-03 22:55     ` Olof Johansson
2005-03-03 23:14       ` Greg KH
2005-03-04  1:59       ` Andrew Morton
2005-03-04  2:24         ` Olof Johansson
2005-03-04  5:54           ` Chris Wright
2005-03-04  6:06             ` Jeff Garzik
2005-03-04  6:17               ` Andrew Morton
2005-03-04  6:33                 ` Jeff Garzik
2005-03-04  6:06             ` Andrew Morton
2005-03-04  6:12               ` Jeff Garzik
2005-03-04  6:20                 ` Andrew Morton
2005-03-04  6:20                 ` Chris Wright
2005-03-04  6:23                   ` Andrew Morton
2005-03-04  6:47                     ` Chris Wright
2005-03-04  6:54                       ` Andrew Morton
2005-03-04  7:04                         ` Chris Wright
2005-03-04  7:05                       ` Jeff Garzik
2005-03-04  7:12                         ` Andrew Morton
2005-03-04  7:14                           ` Jeff Garzik
2005-03-04 16:27                     ` Greg KH
2005-03-04 18:38                       ` Linus Torvalds
2005-03-04 18:41                         ` Greg KH
2005-03-06 23:06                       ` Alan Cox
2005-03-07 18:03                         ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050303224515.GA16567@kroah.com \
    --to=greg@kroah.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=rene@exactcode.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox