Re: [2.6 patch] unexport insert_resource

Andrew Morton
2005-04-23T23:47:44Z

Adrian Bunk <bunk@stusta.de> wrote:
>
> I didn't find any possible modular usage in the kernel.
>

True, but this looks like something which out-of-tree code could possibly
be using. I'd prefer to see this one get the deprecated_for_modules
twelve-month treatment.

Or we just leave it as-is. It depends whether insert_resource is a
sensible part of the resource management API (I think it is). If so,
then we should just leave it exported, whether or not any in-kernel moduels
happen to be using it at this point in time.

>
> --- linux-2.6.11-rc5-mm1-full/kernel/resource.c.old 2005-03-04 01:01:30.000000000 +0100
> +++ linux-2.6.11-rc5-mm1-full/kernel/resource.c 2005-03-04 01:01:42.000000000 +0100
> @@ -371,8 +371,6 @@
> return result;
> }
>
> -EXPORT_SYMBOL(insert_resource);
> -
> /*
> * Given an existing resource, change its start and size to match the
> * arguments. Returns -EBUSY if it can't fit. Existing children of