From: Andrew Morton <akpm@osdl.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: rjw@sisk.pl, linux-kernel@vger.kernel.org, hugang@soulinfo.com
Subject: Re: swsusp: use non-contiguous memory on resume
Date: Fri, 4 Mar 2005 02:13:47 -0800 [thread overview]
Message-ID: <20050304021347.1b3e0122.akpm@osdl.org> (raw)
In-Reply-To: <20050304095934.GA1731@elf.ucw.cz>
Pavel Machek <pavel@ucw.cz> wrote:
>
> Subject: non-contiguous pagedir for resume
>
> This fixes problem where we could have enough memory but not in
> continuous chunk, and resume would fail.
It seems to do more that that? What's all the assembly stuff?
General point: this changlog entry doesn't describe the problem and it
doesn't describe how the patch fixes that problem. It's a model how-not-to ;)
> --- linux-mm/kernel/power/swsusp.c 2005-02-28 01:14:08.000000000 +0100
> +++ linux.middle/kernel/power/swsusp.c 2005-02-28 21:29:06.000000000 +0100
> @@ -241,7 +241,7 @@
> swp_entry_t entry;
> int error = 0;
>
> - entry = get_swap_page(NULL, swp_offset(*loc));
> + entry = get_swap_page();
Something's gone wrong here. In -mm, get_swap_page() takes two args and in
-linus it takes zero args.
next prev parent reply other threads:[~2005-03-04 10:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-04 9:59 swsusp: use non-contiguous memory on resume Pavel Machek
2005-03-04 10:13 ` Andrew Morton [this message]
2005-03-04 10:21 ` Pavel Machek
2005-03-04 10:51 ` Andrew Morton
2005-03-04 11:01 ` Pavel Machek
2005-03-04 11:29 ` Andrew Morton
2005-03-04 11:52 ` Pavel Machek
2005-03-04 12:00 ` Rafael J. Wysocki
2005-03-04 12:30 ` Pavel Machek
2005-03-04 11:09 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050304021347.1b3e0122.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=hugang@soulinfo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox