From: "Antonino A. Daplas" <adaplas@hotpop.com>
To: Adrian Bunk <bunk@stusta.de>, adaplas@pol.net
Cc: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: RFC: disallow modular framebuffers
Date: Fri, 4 Mar 2005 03:50:42 +0800 [thread overview]
Message-ID: <200503040350.51163.adaplas@hotpop.com> (raw)
In-Reply-To: <20050303165649.GF4608@stusta.de>
On Friday 04 March 2005 00:56, Adrian Bunk wrote:
> On Tue, Mar 01, 2005 at 09:15:27PM +0800, Antonino A. Daplas wrote:
> > On Tuesday 01 March 2005 10:41, Adrian Bunk wrote:
> > > Hi,
> > >
> > > while looking how to fix modular FB_SAVAGE_* (both FB_SAVAGE_I2C=m and
> > > FB_SAVAGE_ACCEL=m are currently broken) I asked myself:
> >
> > BTW, what's the problem with the above?
>
> #if defined(CONFIG_FB_SAVAGE_ACCEL)
>
> doesn't work with FB_SAVAGE_ACCEL=m, and
>
> #if defined(CONFIG_FB_SAVAGE_ACCEL) ||
> defined(CONFIG_FB_SAVAGE_ACCEL_MODULE)
>
> would break with FB_SAVAGE=y and FB_SAVAGE_ACCEL=m.
>
I see.
>
> Is there any reason for these being three modules?
> It seems the best solution would be to make this one module composed of
> up to three object files?
Yes.
Tony
next prev parent reply other threads:[~2005-03-03 20:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-01 2:41 RFC: disallow modular framebuffers Adrian Bunk
2005-03-01 3:46 ` Jeff Garzik
2005-03-01 6:07 ` Jon Smirl
2005-03-01 17:52 ` [Linux-fbdev-devel] " James Simmons
2005-03-01 12:49 ` [Linux-fbdev-devel] " Antonino A. Daplas
2005-03-01 13:15 ` Antonino A. Daplas
2005-03-03 16:56 ` Adrian Bunk
2005-03-03 19:50 ` Antonino A. Daplas [this message]
2005-03-03 20:20 ` Adrian Bunk
2005-03-03 20:37 ` Antonino A. Daplas
2005-03-03 23:07 ` [2.6 patch] make savagefb one module Adrian Bunk
2005-03-04 9:17 ` [Linux-fbdev-devel] " Geert Uytterhoeven
2005-03-05 1:12 ` Adrian Bunk
2005-03-05 20:49 ` Antonino A. Daplas
2005-03-01 16:59 ` RFC: disallow modular framebuffers Jesse Barnes
2005-03-02 11:32 ` [Linux-fbdev-devel] " David Vrabel
2005-03-02 12:17 ` Paul Mundt
2005-03-02 18:01 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200503040350.51163.adaplas@hotpop.com \
--to=adaplas@hotpop.com \
--cc=adaplas@pol.net \
--cc=bunk@stusta.de \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox