From: domen@coderock.org
To: axboe@suse.de
Cc: linux-kernel@vger.kernel.org, domen@coderock.org,
nacc@us.ibm.com, janitor@sternwelten.at
Subject: [patch 03/15] block/swim3: replace direct assignment with set_current_state()
Date: Sat, 05 Mar 2005 23:42:48 +0100 [thread overview]
Message-ID: <20050305224249.ACC821F202@trashy.coderock.org> (raw)
Any comments would be appreciated.
set_current_state() is used instead of direct assignment of
current->state.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/drivers/block/swim3.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff -puN drivers/block/swim3.c~set_current_state-drivers_block_swim3 drivers/block/swim3.c
--- kj/drivers/block/swim3.c~set_current_state-drivers_block_swim3 2005-03-05 16:09:15.000000000 +0100
+++ kj-domen/drivers/block/swim3.c 2005-03-05 16:09:15.000000000 +0100
@@ -832,7 +832,7 @@ static int fd_eject(struct floppy_state
break;
}
swim3_select(fs, RELAX);
- current->state = TASK_INTERRUPTIBLE;
+ set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(1);
if (swim3_readbit(fs, DISK_IN) == 0)
break;
@@ -900,7 +900,7 @@ static int floppy_open(struct inode *ino
break;
}
swim3_select(fs, RELAX);
- current->state = TASK_INTERRUPTIBLE;
+ set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(1);
}
if (err == 0 && (swim3_readbit(fs, SEEK_COMPLETE) == 0
@@ -984,7 +984,7 @@ static int floppy_revalidate(struct gend
if (signal_pending(current))
break;
swim3_select(fs, RELAX);
- current->state = TASK_INTERRUPTIBLE;
+ set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(1);
}
ret = swim3_readbit(fs, SEEK_COMPLETE) == 0
_
reply other threads:[~2005-03-05 22:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050305224249.ACC821F202@trashy.coderock.org \
--to=domen@coderock.org \
--cc=axboe@suse.de \
--cc=janitor@sternwelten.at \
--cc=linux-kernel@vger.kernel.org \
--cc=nacc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox