From: Andrew Morton <akpm@osdl.org>
To: Nish Aravamudan <nish.aravamudan@gmail.com>
Cc: domen@coderock.org, linux-kernel@vger.kernel.org,
nacc@us.ibm.com, mochel@digitalimplant.org, greg@kroah.com
Subject: Re: [patch 12/14] drivers/dmapool: use TASK_UNINTERRUPTIBLE instead of TASK_INTERRUPTIBLE
Date: Sun, 6 Mar 2005 21:31:29 -0800 [thread overview]
Message-ID: <20050306213129.0d6a1504.akpm@osdl.org> (raw)
In-Reply-To: <29495f1d0503062101549b14e8@mail.gmail.com>
Nish Aravamudan <nish.aravamudan@gmail.com> wrote:
>
> > Also, __set_current_state() can be user here: the add_wait_queue() contains
> > the necessary barriers. (Grubby, but we do that in quite a few places with
> > this particular code sequence (we should have an add_wait_queue() variant
> > which does the add_wait_queue+__set_current_state all in one hit (but let's
> > not, else I'll be buried in another 1000 cleanuplets))).
>
> Ok, I will re-spin this patch. Or would you prefer an incremental one?
Let's forget about this one while we work out whether that code is doing
what we want it to do.
prev parent reply other threads:[~2005-03-07 5:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-06 22:36 [patch 12/14] drivers/dmapool: use TASK_UNINTERRUPTIBLE instead of TASK_INTERRUPTIBLE domen
2005-03-07 3:44 ` Andrew Morton
2005-03-07 5:01 ` Nish Aravamudan
2005-03-07 5:31 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050306213129.0d6a1504.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=domen@coderock.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
--cc=nacc@us.ibm.com \
--cc=nish.aravamudan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox