public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: domen@coderock.org
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, domen@coderock.org, nacc@us.ibm.com
Subject: [patch 04/14] ftape/fdc-io: insert set_current_state() before schedule_timeout()
Date: Sun, 06 Mar 2005 23:36:26 +0100	[thread overview]
Message-ID: <20050306223626.D468C1EC90@trashy.coderock.org> (raw)




Inserts a set_current_state(TASK_INTERRUPTIBLE) before the
schedule_timeout() call. Without this change, after the first iteration of the
loop, schedule_timeout() will not only return immediately, but the loop will
break, as the conditional will no longer be satisfied. In fact, this conditional
makes little sense given the workings of schedule_timeout. The timeout variable
is ignored, as well, and I'm fairly certain that it should be included in the
loop conditional. That way, if the timeout expires before a signal hits, -ETIME
will be returned by fdc_interrupt_wait() instead of -EINTR.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Domen Puncer <domen@coderock.org>
---


 kj-domen/drivers/char/ftape/lowlevel/fdc-io.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

diff -puN drivers/char/ftape/lowlevel/fdc-io.c~set_current_state-drivers_char_ftape_lowlevel_fdc-io drivers/char/ftape/lowlevel/fdc-io.c
--- kj/drivers/char/ftape/lowlevel/fdc-io.c~set_current_state-drivers_char_ftape_lowlevel_fdc-io	2005-03-05 16:11:11.000000000 +0100
+++ kj-domen/drivers/char/ftape/lowlevel/fdc-io.c	2005-03-05 16:11:11.000000000 +0100
@@ -387,7 +387,8 @@ int fdc_interrupt_wait(unsigned int time
 
 	set_current_state(TASK_INTERRUPTIBLE);
 	add_wait_queue(&ftape_wait_intr, &wait);
-	while (!ft_interrupt_seen && (current->state == TASK_INTERRUPTIBLE)) {
+	while (!ft_interrupt_seen && timeout) {
+		set_current_state(TASK_INTERRUPTIBLE);
 		timeout = schedule_timeout(timeout);
         }
 
_

                 reply	other threads:[~2005-03-06 22:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050306223626.D468C1EC90@trashy.coderock.org \
    --to=domen@coderock.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nacc@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox