From: Vojtech Pavlik <vojtech@suse.cz>
To: Micheal Marineau <marineam@engr.orst.edu>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] Treat ALPS mouse buttons as mouse buttons
Date: Mon, 7 Mar 2005 07:24:43 +0100 [thread overview]
Message-ID: <20050307062443.GA1570@ucw.cz> (raw)
In-Reply-To: <422BA727.1030506@engr.orst.edu>
On Sun, Mar 06, 2005 at 04:58:15PM -0800, Micheal Marineau wrote:
> The following patch changes the ALPS touchpad driver to treat some mouse
> buttons as mouse buttons rather than what appears to be joystick buttons.
> This is needed for the Dell Inspiron 8500's DualPoint stick buttons. Without
> this patch only the touchpad buttons behave properly.
After investigating the problem deeper it looks like this should already
be fixed in Andrew Morton's -mm tree. Can you try it?
> --- linux-2.6.11/drivers/input/mouse/alps.c 2005-03-01 23:38:13.000000000 -0800
> +++ linux-2.6.11-gentoo-r2/drivers/input/mouse/alps.c 2005-03-06 16:45:07.000000000 -0800
> @@ -97,8 +97,8 @@
>
> input_report_rel(dev, REL_X, x);
> input_report_rel(dev, REL_Y, -y);
> - input_report_key(dev, BTN_A, left);
> - input_report_key(dev, BTN_B, right);
> + input_report_key(dev, BTN_LEFT, left);
> + input_report_key(dev, BTN_RIGHT, right);
> input_sync(dev);
> return;
> }
> @@ -389,8 +389,6 @@
> psmouse->dev.evbit[LONG(EV_REL)] |= BIT(EV_REL);
> psmouse->dev.relbit[LONG(REL_X)] |= BIT(REL_X);
> psmouse->dev.relbit[LONG(REL_Y)] |= BIT(REL_Y);
> - psmouse->dev.keybit[LONG(BTN_A)] |= BIT(BTN_A);
> - psmouse->dev.keybit[LONG(BTN_B)] |= BIT(BTN_B);
>
> psmouse->dev.evbit[LONG(EV_ABS)] |= BIT(EV_ABS);
> input_set_abs_params(&psmouse->dev, ABS_X, 0, 1023, 0, 0);
--
Vojtech Pavlik
SuSE Labs, SuSE CR
prev parent reply other threads:[~2005-03-07 6:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-07 0:58 [PATCH] Treat ALPS mouse buttons as mouse buttons Micheal Marineau
2005-03-07 5:50 ` Vojtech Pavlik
2005-03-07 6:12 ` Micheal Marineau
2005-03-07 6:26 ` Vojtech Pavlik
2005-03-07 6:35 ` Micheal Marineau
2005-03-07 6:57 ` Vojtech Pavlik
2005-03-07 6:24 ` Vojtech Pavlik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050307062443.GA1570@ucw.cz \
--to=vojtech@suse.cz \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marineam@engr.orst.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox