From: Andi Kleen <ak@muc.de>
To: Corey Minyard <minyard@acm.org>
Cc: lkml <linux-kernel@vger.kernel.org>, akpm@osdl.org
Subject: Re: [PATCH] NMI/CMOS RTC race fix for x86-64
Date: 7 Mar 2005 22:53:00 +0100
Date: Mon, 7 Mar 2005 22:53:00 +0100 [thread overview]
Message-ID: <20050307215300.GA36024@muc.de> (raw)
In-Reply-To: <422CBE9F.1090906@acm.org>
> >But in this case it isnt. Instead of all this complexity
> >just remove the NMI reassert code from the NMI handler.
> >It is oudated and mostly useless on modern systems anyways.
> >
> >
> "mostly useless" and "completely useless" are two different things.
It's completely useless (double checked the AMD8111 and ICH5 data sheets)
There is nothing that should ever clear the NMI bit in this register.
In fact the ICH5 datasheet even explicitely says software should
never touch this bit.
It may have some meaning in ancient ISA chipsets, but that is
of no concern on x86-64.
> Do you want me to submit a patch that simply removes this?
Yes, please.
-Andi
next prev parent reply other threads:[~2005-03-07 22:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-07 18:48 [PATCH] NMI/CMOS RTC race fix for x86-64 Corey Minyard
2005-03-07 19:08 ` Andi Kleen
2005-03-07 20:50 ` Corey Minyard
2005-03-07 21:53 ` Andi Kleen [this message]
2005-03-07 23:33 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050307215300.GA36024@muc.de \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox