From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Christoph Hellwig <hch@infradead.org>,
Hugh Dickins <hugh@veritas.com>, Adrian Bunk <bunk@stusta.de>,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] mm/swap_state.c: unexport swapper_space
Date: Tue, 8 Mar 2005 09:09:43 +0000 [thread overview]
Message-ID: <20050308090943.A26847@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20050306224912.GE5827@infradead.org>; from hch@infradead.org on Sun, Mar 06, 2005 at 10:49:12PM +0000
On Sun, Mar 06, 2005 at 10:49:12PM +0000, Christoph Hellwig wrote:
> I disagree. swapper_state is far too much of an internal detail to be
> exported. I argued that way when page_mapping was changed to use it and
> that's why the architectures moved their helpers out of line.
> Looks like the exported unfortunately got added anyway although we settled
> that discussion.
Well, since ARM's usage of page_mapping() is out of line (which is
where it'll now stay) I think Christoph is correct. Maybe this is
something which should be aired on linux-arch for the other arch
maintainers?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-03-08 9:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-06 14:47 [2.6 patch] mm/swap_state.c: unexport swapper_space Adrian Bunk
2005-03-06 15:28 ` Hugh Dickins
2005-03-06 22:49 ` Christoph Hellwig
2005-03-08 9:09 ` Russell King [this message]
2005-03-08 11:45 ` Hugh Dickins
-- strict thread matches above, loose matches on Subject: below --
2005-03-25 1:11 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050308090943.A26847@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=bunk@stusta.de \
--cc=hch@infradead.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox