From: Alan Cox <alan@redhat.com>
To: Greg KH <greg@kroah.com>
Cc: alan@redhat.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
luc@saillard.org, torvalds@osdl.org
Subject: Re: [PATCH] Restore PWC driver
Date: Tue, 8 Mar 2005 04:59:38 -0500 [thread overview]
Message-ID: <20050308095938.GA30673@devserv.devel.redhat.com> (raw)
In-Reply-To: <20050308052643.GA16222@kroah.com>
On Mon, Mar 07, 2005 at 09:26:43PM -0800, Greg KH wrote:
> As it is, the coding style sucks in places, and you didn't really need
> to make it a new subdirectory (although due to the increased size of the
> driver, it's probably better now...)
Luc I assume
> And, there's no MAINTAINERS entry for who I need to bug about this
> thing.
Try the email address at the top of the files.. ?
> So, who's going to fix up:
> - the MAINTAINERS entry
> - the coding style
> - drop that unneeded changelog file
> - fix the module help text to point to the proper file (or put
> the file in the proper place.)
> - get rid of the c++ crud in the header file
> - drop the "magic" nonsense
> - the ioctls to work on 64bit machines
> ?
Luc and I'm happy to help doing further work on it. However it's been like that
in kernel for years so it might also be a good one for the janitors to join in
on ?
next prev parent reply other threads:[~2005-03-08 10:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200503072216.j27MGLqR024373@hera.kernel.org>
2005-03-08 5:26 ` [PATCH] Restore PWC driver Greg KH
2005-03-08 5:32 ` Greg KH
2005-03-08 10:01 ` Alan Cox
2005-03-08 5:34 ` Christoph Hellwig
2005-03-08 10:01 ` Alan Cox
2005-03-08 11:11 ` Andrew Morton
2005-03-08 8:15 ` Luc Saillard
2005-03-08 10:03 ` Alan Cox
2005-03-08 9:59 ` Alan Cox [this message]
2005-03-08 14:13 ` Martin Hicks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050308095938.GA30673@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luc@saillard.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox