public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Domen Puncer <domen@coderock.org>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, sebek64@post.cz
Subject: Re: [patch 07/12] Re: radio-sf16fmi cleanup
Date: Tue, 8 Mar 2005 11:27:19 +0100	[thread overview]
Message-ID: <20050308102719.GF18117@nd47.coderock.org> (raw)
In-Reply-To: <20050306164047.5cdfcd8b.akpm@osdl.org>

On 06/03/05 16:40 -0800, Andrew Morton wrote:
> domen@coderock.org wrote:
> >
> > 
> > This is small cleanup of radio-sf16fmi driver.
> 
> Well, yes, but it is a functional change, no?
> 
> Previously the kernel accepted the `sf16fm=' option.  Now the users must
> switch over to, umm, `radio-sf16fmi.io=', yes?

Right.

> 
> 
> 
> > Signed-off-by: Marcel Sebek <sebek64@post.cz>
> > Signed-off-by: Domen Puncer <domen@coderock.org>
> > ---
> > 
> > 
> >  kj-domen/Documentation/kernel-parameters.txt |    3 ---
> >  kj-domen/drivers/media/radio/radio-sf16fmi.c |   10 ----------
> >  2 files changed, 13 deletions(-)
> > 
> > diff -puN Documentation/kernel-parameters.txt~kill_kernel_parameter-sf16fm Documentation/kernel-parameters.txt
> > --- kj/Documentation/kernel-parameters.txt~kill_kernel_parameter-sf16fm	2005-03-05 16:11:31.000000000 +0100
> > +++ kj-domen/Documentation/kernel-parameters.txt	2005-03-05 16:11:31.000000000 +0100
> > @@ -1148,9 +1148,6 @@ running once the system is up.
> >  
> >  	serialnumber	[BUGS=IA-32]
> >  
> > -	sf16fm=		[HW] SF16FMI radio driver for Linux
> > -			Format: <io>
> > -
> >  	sg_def_reserved_size=
> >  			[SCSI]
> >   
> > diff -puN drivers/media/radio/radio-sf16fmi.c~kill_kernel_parameter-sf16fm drivers/media/radio/radio-sf16fmi.c
> > --- kj/drivers/media/radio/radio-sf16fmi.c~kill_kernel_parameter-sf16fm	2005-03-05 16:11:31.000000000 +0100
> > +++ kj-domen/drivers/media/radio/radio-sf16fmi.c	2005-03-05 16:11:31.000000000 +0100
> > @@ -326,13 +326,3 @@ static void __exit fmi_cleanup_module(vo
> >  
> >  module_init(fmi_init);
> >  module_exit(fmi_cleanup_module);
> > -
> > -#ifndef MODULE
> > -static int __init fmi_setup_io(char *str)
> > -{
> > -	get_option(&str, &io);
> > -	return 1;
> > -}
> > -
> > -__setup("sf16fm=", fmi_setup_io);
> > -#endif
> > _

      reply	other threads:[~2005-03-08 10:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-05 15:35 [patch 07/12] Re: radio-sf16fmi cleanup domen
2005-03-07  0:40 ` Andrew Morton
2005-03-08 10:27   ` Domen Puncer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050308102719.GF18117@nd47.coderock.org \
    --to=domen@coderock.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sebek64@post.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox