* [patch 07/12] Re: radio-sf16fmi cleanup
@ 2005-03-05 15:35 domen
2005-03-07 0:40 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: domen @ 2005-03-05 15:35 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, domen, sebek64
This is small cleanup of radio-sf16fmi driver.
Signed-off-by: Marcel Sebek <sebek64@post.cz>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/Documentation/kernel-parameters.txt | 3 ---
kj-domen/drivers/media/radio/radio-sf16fmi.c | 10 ----------
2 files changed, 13 deletions(-)
diff -puN Documentation/kernel-parameters.txt~kill_kernel_parameter-sf16fm Documentation/kernel-parameters.txt
--- kj/Documentation/kernel-parameters.txt~kill_kernel_parameter-sf16fm 2005-03-05 16:11:31.000000000 +0100
+++ kj-domen/Documentation/kernel-parameters.txt 2005-03-05 16:11:31.000000000 +0100
@@ -1148,9 +1148,6 @@ running once the system is up.
serialnumber [BUGS=IA-32]
- sf16fm= [HW] SF16FMI radio driver for Linux
- Format: <io>
-
sg_def_reserved_size=
[SCSI]
diff -puN drivers/media/radio/radio-sf16fmi.c~kill_kernel_parameter-sf16fm drivers/media/radio/radio-sf16fmi.c
--- kj/drivers/media/radio/radio-sf16fmi.c~kill_kernel_parameter-sf16fm 2005-03-05 16:11:31.000000000 +0100
+++ kj-domen/drivers/media/radio/radio-sf16fmi.c 2005-03-05 16:11:31.000000000 +0100
@@ -326,13 +326,3 @@ static void __exit fmi_cleanup_module(vo
module_init(fmi_init);
module_exit(fmi_cleanup_module);
-
-#ifndef MODULE
-static int __init fmi_setup_io(char *str)
-{
- get_option(&str, &io);
- return 1;
-}
-
-__setup("sf16fm=", fmi_setup_io);
-#endif
_
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch 07/12] Re: radio-sf16fmi cleanup
2005-03-05 15:35 [patch 07/12] Re: radio-sf16fmi cleanup domen
@ 2005-03-07 0:40 ` Andrew Morton
2005-03-08 10:27 ` Domen Puncer
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2005-03-07 0:40 UTC (permalink / raw)
To: domen; +Cc: linux-kernel, domen, sebek64
domen@coderock.org wrote:
>
>
> This is small cleanup of radio-sf16fmi driver.
Well, yes, but it is a functional change, no?
Previously the kernel accepted the `sf16fm=' option. Now the users must
switch over to, umm, `radio-sf16fmi.io=', yes?
> Signed-off-by: Marcel Sebek <sebek64@post.cz>
> Signed-off-by: Domen Puncer <domen@coderock.org>
> ---
>
>
> kj-domen/Documentation/kernel-parameters.txt | 3 ---
> kj-domen/drivers/media/radio/radio-sf16fmi.c | 10 ----------
> 2 files changed, 13 deletions(-)
>
> diff -puN Documentation/kernel-parameters.txt~kill_kernel_parameter-sf16fm Documentation/kernel-parameters.txt
> --- kj/Documentation/kernel-parameters.txt~kill_kernel_parameter-sf16fm 2005-03-05 16:11:31.000000000 +0100
> +++ kj-domen/Documentation/kernel-parameters.txt 2005-03-05 16:11:31.000000000 +0100
> @@ -1148,9 +1148,6 @@ running once the system is up.
>
> serialnumber [BUGS=IA-32]
>
> - sf16fm= [HW] SF16FMI radio driver for Linux
> - Format: <io>
> -
> sg_def_reserved_size=
> [SCSI]
>
> diff -puN drivers/media/radio/radio-sf16fmi.c~kill_kernel_parameter-sf16fm drivers/media/radio/radio-sf16fmi.c
> --- kj/drivers/media/radio/radio-sf16fmi.c~kill_kernel_parameter-sf16fm 2005-03-05 16:11:31.000000000 +0100
> +++ kj-domen/drivers/media/radio/radio-sf16fmi.c 2005-03-05 16:11:31.000000000 +0100
> @@ -326,13 +326,3 @@ static void __exit fmi_cleanup_module(vo
>
> module_init(fmi_init);
> module_exit(fmi_cleanup_module);
> -
> -#ifndef MODULE
> -static int __init fmi_setup_io(char *str)
> -{
> - get_option(&str, &io);
> - return 1;
> -}
> -
> -__setup("sf16fm=", fmi_setup_io);
> -#endif
> _
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch 07/12] Re: radio-sf16fmi cleanup
2005-03-07 0:40 ` Andrew Morton
@ 2005-03-08 10:27 ` Domen Puncer
0 siblings, 0 replies; 3+ messages in thread
From: Domen Puncer @ 2005-03-08 10:27 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, sebek64
On 06/03/05 16:40 -0800, Andrew Morton wrote:
> domen@coderock.org wrote:
> >
> >
> > This is small cleanup of radio-sf16fmi driver.
>
> Well, yes, but it is a functional change, no?
>
> Previously the kernel accepted the `sf16fm=' option. Now the users must
> switch over to, umm, `radio-sf16fmi.io=', yes?
Right.
>
>
>
> > Signed-off-by: Marcel Sebek <sebek64@post.cz>
> > Signed-off-by: Domen Puncer <domen@coderock.org>
> > ---
> >
> >
> > kj-domen/Documentation/kernel-parameters.txt | 3 ---
> > kj-domen/drivers/media/radio/radio-sf16fmi.c | 10 ----------
> > 2 files changed, 13 deletions(-)
> >
> > diff -puN Documentation/kernel-parameters.txt~kill_kernel_parameter-sf16fm Documentation/kernel-parameters.txt
> > --- kj/Documentation/kernel-parameters.txt~kill_kernel_parameter-sf16fm 2005-03-05 16:11:31.000000000 +0100
> > +++ kj-domen/Documentation/kernel-parameters.txt 2005-03-05 16:11:31.000000000 +0100
> > @@ -1148,9 +1148,6 @@ running once the system is up.
> >
> > serialnumber [BUGS=IA-32]
> >
> > - sf16fm= [HW] SF16FMI radio driver for Linux
> > - Format: <io>
> > -
> > sg_def_reserved_size=
> > [SCSI]
> >
> > diff -puN drivers/media/radio/radio-sf16fmi.c~kill_kernel_parameter-sf16fm drivers/media/radio/radio-sf16fmi.c
> > --- kj/drivers/media/radio/radio-sf16fmi.c~kill_kernel_parameter-sf16fm 2005-03-05 16:11:31.000000000 +0100
> > +++ kj-domen/drivers/media/radio/radio-sf16fmi.c 2005-03-05 16:11:31.000000000 +0100
> > @@ -326,13 +326,3 @@ static void __exit fmi_cleanup_module(vo
> >
> > module_init(fmi_init);
> > module_exit(fmi_cleanup_module);
> > -
> > -#ifndef MODULE
> > -static int __init fmi_setup_io(char *str)
> > -{
> > - get_option(&str, &io);
> > - return 1;
> > -}
> > -
> > -__setup("sf16fm=", fmi_setup_io);
> > -#endif
> > _
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-03-08 10:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-05 15:35 [patch 07/12] Re: radio-sf16fmi cleanup domen
2005-03-07 0:40 ` Andrew Morton
2005-03-08 10:27 ` Domen Puncer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox