From: Pavel Machek <pavel@ucw.cz>
To: "David S. Miller" <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, akpm@zip.com.au, jgarzik@pobox.com,
linux-net@vger.kernel.org
Subject: Re: Fix suspend/resume problems with b44
Date: Tue, 8 Mar 2005 22:55:37 +0100 [thread overview]
Message-ID: <20050308215537.GD24188@elf.ucw.cz> (raw)
In-Reply-To: <20050308101739.371968be.davem@davemloft.net>
Hi!
> > @@ -1934,6 +1936,9 @@
> > if (!netif_running(dev))
> > return 0;
> >
> > + if (request_irq(dev->irq, b44_interrupt, SA_SHIRQ, dev->name, dev))
> > + printk(KERN_ERR PFX "%s: request_irq failed\n", dev->name);
> > +
>
> This is a hard error and means that bringup of the chip
> will totally fail. It definitely deserves something harder
> than a printk(), but unfortunately ->resume() has no way
> to cleanly fail.
Any idea what to do there? I'd say that request_irq is very unlikely
to fail given that it worked okay before suspend...
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next prev parent reply other threads:[~2005-03-08 21:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-08 9:46 Fix suspend/resume problems with b44 Pavel Machek
2005-03-08 18:17 ` David S. Miller
2005-03-08 21:55 ` Pavel Machek [this message]
2005-03-09 3:40 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050308215537.GD24188@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@zip.com.au \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox