public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: dtor_core@ameritech.net, Borislav Petkov <petkov@uni-muenster.de>,
	perex@suse.cz, vojtech@suse.cz, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-input@atrey.karlin.mff.cuni.cz
Subject: [2.6 patch] OSS gameport fixes
Date: Wed, 9 Mar 2005 12:32:17 +0100	[thread overview]
Message-ID: <20050309113217.GB21688@stusta.de> (raw)
In-Reply-To: <20050307230633.GJ3170@stusta.de>

This patch adds dummy gameport_register_port, gameport_unregister_port 
and gameport_set_phys functions to gameport.h for the case when a driver 
can't use gameport.

This fixes the compilation of some OSS drivers with GAMEPORT=n without 
the need to #if inside every single driver.

This patch also removes the non-working and now obsolete SOUND_GAMEPORT.

This patch is also an alternative solution for ALSA drivers with similar 
problems (but #if's inside the drivers might have the advantage of 
saving some more bytes of gameport is not available).

The only user-visible change is that for GAMEPORT=m the affected OSS 
drivers are now allowed to be built statically (but they won't have 
gameport support).

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/input/gameport/Kconfig |   20 --------------------
 include/linux/gameport.h       |   28 +++++++++++++++++++++++++---
 sound/oss/Kconfig              |   12 ++++++------
 3 files changed, 31 insertions(+), 29 deletions(-)

--- linux-2.6.11-mm2-full/include/linux/gameport.h.old	2005-03-09 06:25:41.000000000 +0100
+++ linux-2.6.11-mm2-full/include/linux/gameport.h	2005-03-09 06:41:58.000000000 +0100
@@ -67,6 +67,8 @@
 void gameport_close(struct gameport *gameport);
 void gameport_rescan(struct gameport *gameport);
 
+#if defined(CONFIG_GAMEPORT) || (defined(MODULE) && defined(CONFIG_GAMEPORT_MODULE))
+
 void __gameport_register_port(struct gameport *gameport, struct module *owner);
 static inline void gameport_register_port(struct gameport *gameport)
 {
@@ -75,6 +77,29 @@
 
 void gameport_unregister_port(struct gameport *gameport);
 
+void gameport_set_phys(struct gameport *gameport, const char *fmt, ...)
+	__attribute__ ((format (printf, 2, 3)));
+
+#else
+
+static inline void gameport_register_port(struct gameport *gameport)
+{
+	return;
+}
+
+static inline void gameport_unregister_port(struct gameport *gameport)
+{
+	return;
+}
+
+static inline void gameport_set_phys(struct gameport *gameport,
+				     const char *fmt, ...)
+{
+	return;
+}
+
+#endif
+
 static inline struct gameport *gameport_allocate_port(void)
 {
 	struct gameport *gameport = kcalloc(1, sizeof(struct gameport), GFP_KERNEL);
@@ -92,9 +117,6 @@
 	strlcpy(gameport->name, name, sizeof(gameport->name));
 }
 
-void gameport_set_phys(struct gameport *gameport, const char *fmt, ...)
-	__attribute__ ((format (printf, 2, 3)));
-
 /*
  * Use the following fucntions to manipulate gameport's per-port
  * driver-specific data.
--- linux-2.6.11-mm2-full/drivers/input/gameport/Kconfig.old	2005-03-09 06:20:28.000000000 +0100
+++ linux-2.6.11-mm2-full/drivers/input/gameport/Kconfig	2005-03-09 06:20:56.000000000 +0100
@@ -64,23 +64,3 @@
 	tristate "Crystal SoundFusion gameport support"
 
 endif
-
-# Yes, SOUND_GAMEPORT looks a bit odd. Yes, it ends up being turned on
-# in every .config. Please don't touch it. It is here to handle an
-# unusual dependency between GAMEPORT and sound drivers.
-#
-# Some sound drivers call gameport functions. If GAMEPORT is
-# not selected, empty stubs are provided for the functions and all is
-# well.
-# If GAMEPORT is built in, everything is fine.
-# If GAMEPORT is a module, however, it would need to be loaded for the
-# sound driver to be able to link properly. Therefore, the sound
-# driver must be a module as well in that case. Since there's no way
-# to express that directly in Kconfig, we use SOUND_GAMEPORT to
-# express it. SOUND_GAMEPORT boils down to "if GAMEPORT is 'm',
-# anything that depends on SOUND_GAMEPORT must be 'm' as well. if
-# GAMEPORT is 'y' or 'n', it can be anything".
-config SOUND_GAMEPORT
-	tristate
-	default m if GAMEPORT=m
-	default y
--- linux-2.6.11-mm2-full/sound/oss/Kconfig.old	2005-03-09 06:21:05.000000000 +0100
+++ linux-2.6.11-mm2-full/sound/oss/Kconfig	2005-03-09 06:28:29.000000000 +0100
@@ -112,7 +112,7 @@
 
 config SOUND_ES1370
 	tristate "Ensoniq AudioPCI (ES1370)"
-	depends on SOUND_PRIME!=n && SOUND && PCI && SOUND_GAMEPORT
+	depends on SOUND_PRIME!=n && SOUND && PCI
 	help
 	  Say Y or M if you have a PCI sound card utilizing the Ensoniq
 	  ES1370 chipset, such as Ensoniq's AudioPCI (non-97). To find
@@ -125,7 +125,7 @@
 
 config SOUND_ES1371
 	tristate "Creative Ensoniq AudioPCI 97 (ES1371)"
-	depends on SOUND_PRIME!=n && SOUND && PCI && SOUND_GAMEPORT
+	depends on SOUND_PRIME!=n && SOUND && PCI
 	help
 	  Say Y or M if you have a PCI sound card utilizing the Ensoniq
 	  ES1371 chipset, such as Ensoniq's AudioPCI97. To find out if
@@ -138,7 +138,7 @@
 
 config SOUND_ESSSOLO1
 	tristate "ESS Technology Solo1" 
-	depends on SOUND_PRIME!=n && SOUND && SOUND_GAMEPORT && PCI
+	depends on SOUND_PRIME!=n && SOUND && PCI
 	help
 	  Say Y or M if you have a PCI sound card utilizing the ESS Technology
 	  Solo1 chip. To find out if your sound card uses a
@@ -179,7 +179,7 @@
 
 config SOUND_SONICVIBES
 	tristate "S3 SonicVibes"
-	depends on SOUND_PRIME!=n && SOUND && SOUND_GAMEPORT
+	depends on SOUND_PRIME!=n && SOUND
 	help
 	  Say Y or M if you have a PCI sound card utilizing the S3
 	  SonicVibes chipset. To find out if your sound card uses a
@@ -226,7 +226,7 @@
 
 config SOUND_TRIDENT
 	tristate "Trident 4DWave DX/NX, SiS 7018 or ALi 5451 PCI Audio Core"
-	depends on SOUND_PRIME!=n && SOUND && SOUND_GAMEPORT
+	depends on SOUND_PRIME!=n && SOUND
 	---help---
 	  Say Y or M if you have a PCI sound card utilizing the Trident
 	  4DWave-DX/NX chipset or your mother board chipset has SiS 7018
@@ -739,7 +739,7 @@
 
 config SOUND_MAD16
 	tristate "OPTi MAD16 and/or Mozart based cards"
-	depends on SOUND_OSS && SOUND_GAMEPORT
+	depends on SOUND_OSS
 	---help---
 	  Answer Y if your card has a Mozart (OAK OTI-601) or MAD16 (OPTi
 	  82C928 or 82C929 or 82C931) audio interface chip. These chips are

  parent reply	other threads:[~2005-03-09 11:33 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-04 11:32 2.6.11-mm1 Andrew Morton
2005-03-04 13:59 ` 2.6.11-mm1 Aurélien Francillon
2005-03-04 14:19   ` 2.6.11-mm1 Aurélien Francillon
2005-03-04 16:44 ` 2.6.11-mm1 (compile stats) John Cherry
2005-03-04 22:16 ` 2.6.11-mm1 Alexander Nyberg
2005-03-04 22:39   ` 2.6.11-mm1 Andrew Morton
2005-03-04 22:55     ` 2.6.11-mm1 Alexander Nyberg
2005-03-08 21:31       ` 2.6.11-mm1 Alexander Nyberg
2005-03-07  8:41 ` 2.6.11-mm1 Borislav Petkov
2005-03-07 21:52   ` 2.6.11-mm1: sound <-> GAMEPORT problems Adrian Bunk
2005-03-07 22:05     ` Dmitry Torokhov
2005-03-07 22:12     ` Dmitry Torokhov
2005-03-07 23:06       ` [2.6 patch] sound/pci/cs4281.c fix typos in the SUPPORT_JOYSTICK=n case Adrian Bunk
2005-03-08 10:24         ` Vojtech Pavlik
2005-03-09 11:32         ` Adrian Bunk [this message]
2005-03-10 15:36           ` [2.6 patch] OSS gameport fixes Dmitry Torokhov
2005-03-10 15:57             ` Vojtech Pavlik
2005-03-07  8:51 ` 2.6.11-mm1 Guillaume Thouvenin
2005-03-07  8:58   ` 2.6.11-mm1 Andrew Morton
2005-03-07 23:45     ` 2.6.11-mm1 Greg KH
2005-03-07 23:07 ` [-mm patch] sound/oss/soundcard.c: remove an unused variable Adrian Bunk
2005-03-08  2:33   ` Jesper Juhl
2005-03-10 17:21 ` 2.6.11-mm1 Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050309113217.GB21688@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=dtor_core@ameritech.net \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    --cc=petkov@uni-muenster.de \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox