From: olof@austin.ibm.com (Olof Johansson)
To: Jake Moilanen <moilanen@austin.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>,
linuxppc64-dev@ozlabs.org, linux-kernel@vger.kernel.org,
Anton Blanchard <anton@samba.org>,
paulus@samba.org
Subject: Re: [PATCH 2/2] No-exec support for ppc64
Date: Wed, 9 Mar 2005 21:25:07 -0600 [thread overview]
Message-ID: <20050310032507.GC20789@austin.ibm.com> (raw)
In-Reply-To: <20050308171326.3d72363a.moilanen@austin.ibm.com>
Hi,
On Tue, Mar 08, 2005 at 05:13:26PM -0600, Jake Moilanen wrote:
> diff -puN arch/ppc64/mm/hash_utils.c~nx-kernel-ppc64 arch/ppc64/mm/hash_utils.c
> --- linux-2.6-bk/arch/ppc64/mm/hash_utils.c~nx-kernel-ppc64 2005-03-08 16:08:57 -06:00
> +++ linux-2.6-bk-moilanen/arch/ppc64/mm/hash_utils.c 2005-03-08 16:08:57 -06:00
> @@ -89,12 +90,23 @@ static inline void loop_forever(void)
> ;
> }
>
> +int is_kernel_text(unsigned long addr)
> +{
> + if (addr >= (unsigned long)_stext && addr < (unsigned long)__init_end)
> + return 1;
> +
> + return 0;
> +}
This is used in two files, but never declared extern in the second file
(iSeries_setup.c). Should it go in a header file as a static inline
instead?
There also seems to be a local static is_kernel_text() in kallsyms that
overlaps (but it's not identical). Removing that redundancy can be taken
care of as a janitorial patch outside of the noexec stuff.
-Olof
next prev parent reply other threads:[~2005-03-10 3:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-08 22:59 [PATCH 0/2] No-exec support for ppc64 Jake Moilanen
2005-03-08 23:08 ` [PATCH 1/2] " Jake Moilanen
2005-03-10 3:22 ` Olof Johansson
2005-03-10 22:25 ` Jake Moilanen
2005-03-14 10:13 ` Paul Mackerras
2005-03-14 21:51 ` Jake Moilanen
2005-03-14 22:18 ` Paul Mackerras
2005-03-15 21:51 ` Jake Moilanen
2005-03-15 22:48 ` Alan Modra
2005-03-15 23:17 ` Jake Moilanen
2005-03-16 6:10 ` Paul Mackerras
2005-03-16 21:45 ` Jake Moilanen
2005-03-08 23:13 ` [PATCH 2/2] " Jake Moilanen
2005-03-09 3:02 ` Benjamin Herrenschmidt
2005-03-10 3:25 ` Olof Johansson [this message]
2005-03-10 7:15 ` Benjamin Herrenschmidt
2005-03-10 22:27 ` Jake Moilanen
2005-03-10 22:44 ` Benjamin Herrenschmidt
2005-03-11 14:01 ` Jake Moilanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050310032507.GC20789@austin.ibm.com \
--to=olof@austin.ibm.com \
--cc=akpm@osdl.org \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=moilanen@austin.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox