public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: linux-kernel@vger.kernel.org, axboe@suse.de
Subject: Re: Direct io on block device has performance regression on 2.6.x kernel
Date: Thu, 10 Mar 2005 12:30:43 -0800	[thread overview]
Message-ID: <20050310123043.69e5fd48.akpm@osdl.org> (raw)
In-Reply-To: <200503101831.j2AIV2g03286@unix-os.sc.intel.com>

"Chen, Kenneth W" <kenneth.w.chen@intel.com> wrote:
>
> Losing 6% just from Linux kernel is a huge deal for this type of benchmark.
>  People work for days to implement features which might give sub percentage
>  gain.  Making Software run faster is not easy, but making software run slower
>  apparently is a fairly easy task.
> 
> 

heh

> 
>  > Fine-grained alignment is probably too hard, and it should fall back to
>  > __blockdev_direct_IO().
>  >
>  > Does it do the right thing with a request which is non-page-aligned, but
>  > 512-byte aligned?
>  >
>  > readv and writev?
>  >
> 
>  That's why direct_io_worker() is slower.  It does everything and handles
>  every possible usage scenarios out there.  I hope making the function fatter
>  is not in the plan.

We just cannot make a change like this if it does not support readv and
writev well, and if it does not support down-to-512-byte size and
alignment.  It will break applications.


  reply	other threads:[~2005-03-10 20:36 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-09  1:39 Direct io on block device has performance regression on 2.6.x kernel Chen, Kenneth W
2005-03-09  6:27 ` Andrew Morton
2005-03-09 17:21   ` Chen, Kenneth W
2005-03-09 20:04     ` Andrew Morton
2005-03-09 21:59       ` Chen, Kenneth W
2005-03-09 22:44         ` Andrew Morton
2005-03-10  1:11           ` Chen, Kenneth W
2005-03-10  1:33             ` Andrew Morton
2005-03-10  1:44               ` Chen, Kenneth W
2005-03-10  2:25     ` Andrew Morton
2005-03-10  3:47       ` Chen, Kenneth W
2005-03-10  4:04         ` David Lang
2005-03-10  4:10           ` Andrew Morton
2005-03-10  4:15             ` Direct io on block device has performance regression on 2.6.xkernel David Lang
2005-03-10  4:09         ` Direct io on block device has performance regression on 2.6.x kernel Andrew Morton
2005-03-10 18:31           ` Chen, Kenneth W
2005-03-10 20:30             ` Andrew Morton [this message]
2005-03-10 21:42               ` Chen, Kenneth W
2005-03-10 22:01                 ` Andrew Morton
2005-03-10  4:28         ` Andrew Vasquez
  -- strict thread matches above, loose matches on Subject: below --
2005-03-09  1:53 Chen, Kenneth W
2005-03-09 22:18 Chen, Kenneth W
2005-03-09 23:23 ` Andi Kleen
2005-03-09 23:52   ` Jesse Barnes
2005-03-09 23:52   ` Jesse Barnes
2005-03-10  1:00     ` Chen, Kenneth W
2005-03-10  0:57   ` Chen, Kenneth W
2005-03-10  1:24 Chen, Kenneth W
2005-03-10  2:04 Chen, Kenneth W

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050310123043.69e5fd48.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=axboe@suse.de \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox