Re: PCI: remove pci_find_device usage from pci sysfs code.

Greg KH
2005-03-21T23:16:16Z

On Sun, Mar 20, 2005 at 03:53:58PM +0100, Rolf Eike Beer wrote:
> Greg KH wrote:
> > ChangeSet 1.1998.11.23, 2005/02/25 08:26:11-08:00, gregkh@suse.de
> >
> > PCI: remove pci_find_device usage from pci sysfs code.
>
> > diff -Nru a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> > --- a/drivers/pci/pci-sysfs.c 2005-03-04 12:41:33 -08:00
> > +++ b/drivers/pci/pci-sysfs.c 2005-03-04 12:41:33 -08:00
> > @@ -481,7 +481,7 @@
> > struct pci_dev *pdev = NULL;
> >
> > sysfs_initialized = 1;
> > - while ((pdev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, pdev)) != NULL)
> > + while ((pdev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, pdev)) != NULL)
> > pci_create_sysfs_dev_files(pdev);
> >
> > return 0;
>
> Any reasons why you are not using "for_each_pci_dev(pdev)" here?

Nope, I forgot it was there :)

Care to send a patch?

thanks,

greg k-h