public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: akpm@osdl.org
Cc: greg@kroah.com, linux-kernel@vger.kernel.org, yuasa@hh.iij4u.or.jp
Subject: Re: [patch 4/5] audit mips fix
Date: Thu, 10 Mar 2005 17:14:29 +0000	[thread overview]
Message-ID: <20050310171429.GB26269@linux-mips.org> (raw)
In-Reply-To: <200503042117.j24LHI7l017973@shell0.pdx.osdl.net>

On Fri, Mar 04, 2005 at 01:16:57PM -0800, akpm@osdl.org wrote:

> Signed-off-by: Yoichi Yuasa <yuasa@hh.iij4u.or.jp>
> Signed-off-by: Andrew Morton <akpm@osdl.org>

> @@ -307,7 +308,7 @@ asmlinkage void do_syscall_trace(struct 
>  {
>  	if (unlikely(current->audit_context)) {
>  		if (!entryexit)
> -			audit_syscall_entry(current, regs->orig_eax,
> +			audit_syscall_entry(current, regs->regs[2],

Wrong.  regs[2] can will contain the syscall return value and can be
modified by ptrace also.

  Ralf

  parent reply	other threads:[~2005-03-10 17:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-04 21:16 [patch 4/5] audit mips fix akpm
2005-03-09 18:58 ` Greg KH
2005-03-10 17:14 ` Ralf Baechle [this message]
2005-03-11  0:58   ` Yoichi Yuasa
2005-03-11 23:24     ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050310171429.GB26269@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yuasa@hh.iij4u.or.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox