public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: linux-kernel@vger.kernel.org, "'Andrew Morton'" <akpm@osdl.org>
Subject: Re: re-inline sched functions
Date: Fri, 11 Mar 2005 10:31:32 +0100	[thread overview]
Message-ID: <20050311093132.GA19954@elte.hu> (raw)
In-Reply-To: <200503110024.j2B0OFg06087@unix-os.sc.intel.com>


* Chen, Kenneth W <kenneth.w.chen@intel.com> wrote:

> # size vmlinux.*
>    text    data     bss     dec     hex filename
> 3261844  717184  262020 4241048  40b698 vmlinux.x86.orig
> 3262772  717488  262020 4242280  40bb68 vmlinux.x86.inline

> Possible we can introduce them back?

> -static unsigned int task_timeslice(task_t *p)
> +static inline unsigned int task_timeslice(task_t *p)

the patch looks good except this one - could you try to undo it and
re-measure? task_timeslice() is not used in any true fastpath, if it
makes any difference then the performance difference must be some other
artifact.

	Ingo

  parent reply	other threads:[~2005-03-11  9:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-11  0:24 re-inline sched functions Chen, Kenneth W
2005-03-11  0:30 ` Andrew Morton
2005-03-11 13:08   ` Nick Piggin
2005-03-11  9:31 ` Ingo Molnar [this message]
2005-03-11 18:39   ` Chen, Kenneth W
  -- strict thread matches above, loose matches on Subject: below --
2005-03-24 21:16 Chen, Kenneth W
2005-03-24 22:22 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050311093132.GA19954@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox