public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: arjan@infradead.org, pbadari@us.ibm.com, dhowells@redhat.com,
	torvalds@osdl.org, suparna@in.ibm.com, linux-aio@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rwsem: Make rwsems use interrupt disabling spinlocks
Date: Fri, 11 Mar 2005 11:25:48 +0100	[thread overview]
Message-ID: <20050311102548.GA24545@elte.hu> (raw)
In-Reply-To: <20050311020717.46794d94.akpm@osdl.org>


* Andrew Morton <akpm@osdl.org> wrote:

> We should arrange for touch_softlockup_watchdog() to be called
> whenever touch_nmi_watchdog() is called.

the patch below adds a touch_softlockup_watchdog() call to every
touch_nmi_watchdog() call.

[A future consolidation patch should introduce a touch_watchdogs() call
that will do both a touch_nmi_watchdog() [if available on the platform]
and a touch_softlockup_watchdog() call.]

Signed-off-by: Ingo Molnar <mingo@elte.hu>

--- linux/arch/x86_64/kernel/nmi.c.orig
+++ linux/arch/x86_64/kernel/nmi.c
@@ -378,6 +378,11 @@ void touch_nmi_watchdog (void)
 	 */
 	for (i = 0; i < NR_CPUS; i++)
 		alert_counter[i] = 0;
+
+	/*
+	 * Tickle the softlockup detector too:
+	 */
+	touch_softlockup_watchdog();
 }
 
 void nmi_watchdog_tick (struct pt_regs * regs, unsigned reason)
--- linux/arch/i386/kernel/nmi.c.orig
+++ linux/arch/i386/kernel/nmi.c
@@ -469,6 +469,11 @@ void touch_nmi_watchdog (void)
 	 */
 	for (i = 0; i < NR_CPUS; i++)
 		alert_counter[i] = 0;
+
+	/*
+	 * Tickle the softlockup detector too:
+	 */
+	touch_softlockup_watchdog();
 }
 
 extern void die_nmi(struct pt_regs *, const char *msg);

  reply	other threads:[~2005-03-11 10:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20050308170107.231a145c.akpm@osdl.org>
     [not found] ` <1110327267.24286.139.camel@dyn318077bld.beaverton.ibm.com>
     [not found]   ` <18744.1110364438@redhat.com>
2005-03-09 11:04     ` aio stress panic on 2.6.11-mm1 Suparna Bhattacharya
2005-03-09 11:05       ` Andrew Morton
2005-03-09 11:07       ` Arjan van de Ven
2005-03-09 11:17         ` Andi Kleen
2005-03-09 11:28         ` Andrew Morton
2005-03-09 11:59           ` David Howells
2005-03-09 12:12           ` [PATCH] rwsem: Make rwsems use interrupt disabling spinlocks David Howells
2005-03-09 17:35             ` Badari Pulavarty
2005-03-09 19:18               ` Badari Pulavarty
2005-03-09 19:16             ` Badari Pulavarty
2005-03-09 19:42               ` Andrew Morton
2005-03-09 20:10                 ` Arjan van de Ven
2005-03-11  9:40                   ` Ingo Molnar
2005-03-11 10:07                     ` Andrew Morton
2005-03-11 10:25                       ` Ingo Molnar [this message]
2005-03-09 11:10       ` aio stress panic on 2.6.11-mm1 Arjan van de Ven
2005-03-09 11:21         ` Andi Kleen
2005-03-09 14:48           ` Suparna Bhattacharya
2005-03-09 21:58         ` David Howells
2005-03-09 11:11       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050311102548.GA24545@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=dhowells@redhat.com \
    --cc=linux-aio@kvack.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbadari@us.ibm.com \
    --cc=suparna@in.ibm.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox