From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Andrea Arcangeli <andrea@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.4 fix for write throttling on x86 >1G
Date: Fri, 11 Mar 2005 13:55:18 -0300 [thread overview]
Message-ID: <20050311165518.GA7412@logos.cnet> (raw)
In-Reply-To: <20050311205309.GD9270@opteron.random>
On Fri, Mar 11, 2005 at 09:53:09PM +0100, Andrea Arcangeli wrote:
> Hello Marcelo,
>
> On Fri, Mar 11, 2005 at 01:04:13PM -0300, Marcelo Tosatti wrote:
> > Out of curiosity, that was SuSE not mainline ?
>
> yep.
>
> > Do we really want to limit dirty cache to low mem on HIGHIO capable
> > machines? I'm afraid doing so might hurt performance on such systems.
> >
> > I think it might be wise to have nr_free_buffer_pages() take highmem
> > into account if CONFIG_HIGHIO is set ?
>
> The problem is the buffercache/blkdev-pagecache: it simply can't go in
> highmem. A similar fix happened recently in 2.6 for the same reasons,
> but in 2.6 we allowed it with some logic specific for the
> blkdev-pagecache.
Right, I dont think it is easy nor wanted to make that distiction in v2.4.
> nr_free_buffer_pages() was never intended to take highmem into account,
> that's why there's the GFP_USER thing already, except we didn't loop
> into the zonelist, so I didn't try to make a fix similar to 2.6.
Hopefully it is not a big deal to not-allow >1GB dirty pagecache on v2.4.
Applied, thanks.
prev parent reply other threads:[~2005-03-11 21:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-11 6:10 2.4 fix for write throttling on x86 >1G Andrea Arcangeli
2005-03-11 16:04 ` Marcelo Tosatti
2005-03-11 20:53 ` Andrea Arcangeli
2005-03-11 16:55 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050311165518.GA7412@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox