Re: [2.6 patch] drivers/net/wan/: possible cleanups

Alan Cox
2005-04-15T17:54:46Z

On Gwe, 2005-04-15 at 00:20, Adrian Bunk wrote:
> On Sun, Mar 27, 2005 at 05:38:38PM +0100, Alan Cox wrote:
> > On Sul, 2005-03-27 at 15:34, Adrian Bunk wrote:
> > > - syncppp.c: sppp_input
> > > - syncppp.c: sppp_change_mtu
> > > - z85230.c: z8530_dma_sync
> > > - z85230.c: z8530_txdma_sync
> >
> > Please leave the z85230 ones at least. They are an intentional part of
> > the external API for writing other 85230 card drivers.
>
> If they are part of an API, why aren't the prototypes for them in any
> header file?

They were once. I guess that got "tided" at some point, possibly long
ago even before submission.

z8530_dma_sync and txdma_sync set up the device in DMA mode, or in DMA
one direction only mode.