Re: [2.6 patch] drivers/net/wan/: possible cleanups

Adrian Bunk
2005-04-17T23:48:07Z

On Fri, Apr 15, 2005 at 06:49:56PM +0100, Alan Cox wrote:
> On Gwe, 2005-04-15 at 00:20, Adrian Bunk wrote:
> > On Sun, Mar 27, 2005 at 05:38:38PM +0100, Alan Cox wrote:
> > > On Sul, 2005-03-27 at 15:34, Adrian Bunk wrote:
> > > > - syncppp.c: sppp_input
> > > > - syncppp.c: sppp_change_mtu
> > > > - z85230.c: z8530_dma_sync
> > > > - z85230.c: z8530_txdma_sync
> > >
> > > Please leave the z85230 ones at least. They are an intentional part of
> > > the external API for writing other 85230 card drivers.
> >
> > If they are part of an API, why aren't the prototypes for them in any
> > header file?
>
> They were once. I guess that got "tided" at some point, possibly long
> ago even before submission.
>...

Are there any external drivers using these exports, and if there are,
why aren't they in the kernel?

If there aren't and someone will at some time in the future need them,
re-adding the exports will be trivial.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed