From: Greg KH <greg@kroah.com>
To: Olaf Hering <olh@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH] be more verbose in gen-devlist
Date: Sat, 12 Mar 2005 12:36:42 -0800 [thread overview]
Message-ID: <20050312203642.GC11865@kroah.com> (raw)
In-Reply-To: <20050311192858.GA11077@suse.de>
On Fri, Mar 11, 2005 at 08:28:58PM +0100, Olaf Hering wrote:
>
> gen-devlist should print how many bytes will be cut off and pci.ids
> entry. Also print the removed '[more blah]' part.
>
> Signed-off-by: Olaf Hering <olh@suse.de>
>
> --- ../linux-2.6.10/drivers/pci/gen-devlist.c 2004-12-24 22:34:45.000000000 +0100
> +++ ./drivers/pci/gen-devlist.c 2005-03-11 20:10:11.542098265 +0100
> @@ -72,9 +72,19 @@ main(void)
> /* Too long, try cutting off long description */
> bra = strchr(c, '[');
> if (bra && bra > c && bra[-1] == ' ')
> +#if 0
> + {
> + fprintf(stderr, "Line %d: cut off '%s' from line:\n", lino, bra);
> + fprintf(stderr, " '%s'\n", c);
> bra[-1] = 0;
> + fprintf(stderr, " '%s'\n", c);
> + }
> +#else
> + bra[-1] = 0;
> +#endif
Why #if this? Why not just always do this?
thanks,
greg k-h
next prev parent reply other threads:[~2005-03-13 0:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-11 19:28 [PATCH] be more verbose in gen-devlist Olaf Hering
2005-03-12 20:36 ` Greg KH [this message]
2005-03-13 8:17 ` Olaf Hering
2005-03-13 8:27 ` Greg KH
2005-03-13 8:33 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050312203642.GC11865@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox