Re: AGP bogosities

Linus Torvalds
2005-03-11T02:36:32Z

On Thu, 10 Mar 2005, Dave Jones wrote:
>
> > /* ARQSZ - Set the value to the maximum one.
> > @@ -642,11 +638,6 @@
> > return 0;
> > }
> > cap_ptr = pci_find_capability(device, PCI_CAP_ID_AGP);
> > - if (!cap_ptr) {
> > - pci_dev_put(device);
> > - continue;
> > - }
> > - cap_ptr = 0;
> > }
>
> This part I'm not so sure about.
> The pci_get_class() call a few lines above will get a refcount that
> we will now never release.

That's the part I rewrote in my version, I think that one is good.

Linus