[PATCH] be more verbose in gen-devlist

[PATCH] be more verbose in gen-devlist

[Olaf Hering]

gen-devlist should print how many bytes will be cut off and pci.ids
entry. Also print the removed '[more blah]' part.

Signed-off-by: Olaf Hering <olh@suse.de>

--- ../linux-2.6.10/drivers/pci/gen-devlist.c	2004-12-24 22:34:45.000000000 +0100
+++ ./drivers/pci/gen-devlist.c	2005-03-11 20:10:11.542098265 +0100
@@ -72,9 +72,19 @@ main(void)
 						/* Too long, try cutting off long description */
 						bra = strchr(c, '[');
 						if (bra && bra > c && bra[-1] == ' ')
+#if 0
+						{
+							fprintf(stderr, "Line %d: cut off '%s' from line:\n", lino, bra);
+							fprintf(stderr, " '%s'\n", c);
 							bra[-1] = 0;
+							fprintf(stderr, " '%s'\n", c);
+						}
+#else
+							bra[-1] = 0;
+#endif
 						if (vendor_len + strlen(c) + 1 > MAX_NAME_SIZE) {
-							fprintf(stderr, "Line %d: Device name too long. Name truncated.\n", lino);
+							fprintf(stderr, "Line %d: Device name %d chars too long. Name truncated.\n",
+									lino, (vendor_len + strlen(c) + 1) - MAX_NAME_SIZE);
 							fprintf(stderr, "%s\n", c);
 							/*return 1;*/
 						}

Re: [PATCH] be more verbose in gen-devlist

[Greg KH]

On Fri, Mar 11, 2005 at 08:28:58PM +0100, Olaf Hering wrote:
> 
> gen-devlist should print how many bytes will be cut off and pci.ids
> entry. Also print the removed '[more blah]' part.
> 
> Signed-off-by: Olaf Hering <olh@suse.de>
> 
> --- ../linux-2.6.10/drivers/pci/gen-devlist.c	2004-12-24 22:34:45.000000000 +0100
> +++ ./drivers/pci/gen-devlist.c	2005-03-11 20:10:11.542098265 +0100
> @@ -72,9 +72,19 @@ main(void)
>  						/* Too long, try cutting off long description */
>  						bra = strchr(c, '[');
>  						if (bra && bra > c && bra[-1] == ' ')
> +#if 0
> +						{
> +							fprintf(stderr, "Line %d: cut off '%s' from line:\n", lino, bra);
> +							fprintf(stderr, " '%s'\n", c);
>  							bra[-1] = 0;
> +							fprintf(stderr, " '%s'\n", c);
> +						}
> +#else
> +							bra[-1] = 0;
> +#endif

Why #if this?  Why not just always do this?

thanks,

greg k-h

Re: [PATCH] be more verbose in gen-devlist

[Olaf Hering]

 On Sat, Mar 12, Greg KH wrote:

> Why #if this?  Why not just always do this?

Because it always triggers with current sf.net snapshot.

Re: [PATCH] be more verbose in gen-devlist

[Greg KH]

On Sun, Mar 13, 2005 at 09:17:09AM +0100, Olaf Hering wrote:
>  On Sat, Mar 12, Greg KH wrote:
> 
> > Why #if this?  Why not just always do this?
> 
> Because it always triggers with current sf.net snapshot.

Someone said they were going to submit those shorter strings that the
kernel has, back to sf.net.  Guess that didn't happen yet, and is the
main reason I can't just sync up all the time with that repository.

Oh well, we'll be dropping support for the pci.ids file by the end of
the year or so, so it's not that big of a deal.

thanks,

greg k-h

Re: [PATCH] be more verbose in gen-devlist

[Olaf Hering]

 On Sun, Mar 13, Greg KH wrote:

> On Sun, Mar 13, 2005 at 09:17:09AM +0100, Olaf Hering wrote:
> >  On Sat, Mar 12, Greg KH wrote:
> > 
> > > Why #if this?  Why not just always do this?
> > 
> > Because it always triggers with current sf.net snapshot.
> 
> Someone said they were going to submit those shorter strings that the
> kernel has, back to sf.net.  Guess that didn't happen yet, and is the
> main reason I can't just sync up all the time with that repository.

I did update the database a few days ago.