From: Dmitry Torokhov <dtor_core@ameritech.net>
To: "Paweł Sikora" <pluto@pld-linux.org>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [2.6.11.3] gcc4 / psmouse.h - compilation fix.
Date: Sun, 13 Mar 2005 12:30:03 -0500 [thread overview]
Message-ID: <200503131230.03938.dtor_core@ameritech.net> (raw)
In-Reply-To: <200503131754.31244.pluto@pld-linux.org>
On Sunday 13 March 2005 11:54, Paweł Sikora wrote:
> On Sunday 13 of March 2005 17:48, Dmitry Torokhov wrote:
> > On Sunday 13 March 2005 08:20, Paweł Sikora wrote:
> > > Hi,
> > >
> > > Attched patch fixes gcc error:
> > > `drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete
> > > type`
> >
> > What file fails compilation?
>
> custom patch for trackpoint device.
>
> > As far as I can see all users of psmouse.h do
> > #include <linux/libps2.h> first.
>
> IMHO each header (e.g. psmouse.h) should include headers for types it uses.
>
Hmm, I thought it was other way around to make it easier to track all users
of a particular header file.
--
Dmitry
next prev parent reply other threads:[~2005-03-13 17:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-13 13:20 [2.6.11.3] gcc4 / psmouse.h - compilation fix Paweł Sikora
2005-03-13 16:48 ` Dmitry Torokhov
2005-03-13 16:54 ` Paweł Sikora
2005-03-13 17:30 ` Dmitry Torokhov [this message]
2005-03-13 21:37 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200503131230.03938.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pluto@pld-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox